Review main Merged

88535[BUGFIX] Correctly apply values in move record notifications

Oli Bartsch CR +2 V +2 Easy +6 −6 updated 03/10/25, 12:07

Commit message

When using lll(), any `%s` placeholder is automatically
replaced by the given arguments in the function call,
or "undefined", in case no arguments are given.

Therefore, applying dynamic values has to be done via
mentioned arguments. The result of lll() does no longer
contain the "%s" placeholders.

Additionally, the wrong label identifier is fixed
for the copy message.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Oli Bartsch uploaded patch set 1 03/07/25, 15:56

  2. core-ci voted on patch set 1 V +1 03/07/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75316

  3. Andreas Kienast commented on patch set 1 03/07/25, 16:07

    We probably have the same issue in move-page.ts.
  4. Oli Bartsch uploaded patch set 2 V +1 03/07/25, 18:31

  5. Oli Bartsch uploaded patch set 3 03/07/25, 18:31

  6. Oli Bartsch commented on patch set 3 03/07/25, 18:35

    Reply

    Yes 👍
  7. core-ci voted on patch set 2 V -1 03/07/25, 18:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75320

  8. core-ci voted on patch set 3 V +1 03/07/25, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75321

  9. Garvin Hicking updated the commit message in patch set 4 V +1 03/07/25, 19:04

  10. Garvin Hicking voted on patch set 4 CR +1 V +1 03/07/25, 19:05

  11. core-ci voted on patch set 4 V +1 03/07/25, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75322

  12. Andreas Kienast voted on patch set 4 CR +1 V +1 03/10/25, 10:54

  13. Benjamin Kott voted on patch set 4 CR +2 V +2 03/10/25, 12:00

  14. Benjamin Kott merged patch set 5 03/10/25, 12:07