88537[BUGFIX] Fix preview with extendToSubpages
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 4
- Bug #106336403 Page Not Found when previewing not hidden page of hidden parent, both with extendToSubpages=1
- Bug #17599Frontend preview doesn't work for subpages of hidden and restricted pages
- Bug #92675Page preview not possible if page inherits fe_group access
- Bug #92286?ADMCMD_simUser= not automatically appended to URL for child page of page with FE group
Files 1
Review log 2026
Show 1 earlier messages
-
Sybille Peters uploaded patch set 1 03/07/25, 17:27
-
core-ci voted on patch set 1 V +1 03/07/25, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75318
-
Sybille Peters commented on patch set 1 03/07/25, 17:49
The behaviour if logged in is now better (no 403), but if not logged in, it still shows 403 error. It should be 404. -
Sybille Peters uploaded patch set 2
V +103/07/25, 18:00 -
Sybille Peters commented on patch set 1 03/07/25, 18:00
Reply
Done -
core-ci voted on patch set 2 V -1 03/07/25, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75319
-
Garvin Hicking commented on patch set 2 03/07/25, 19:09
Didn't dig into this yet, but did you see #17599 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/79656) which specifically introduced this checks for a case - does this aspect still work with the removal? -
Sybille Peters uploaded patch set 3
V -103/08/25, 09:17 -
Sybille Peters commented on patch set 2 03/08/25, 09:20
Reply
I removed the change in FE with not logged in (403 => 404). Some tests failed and it looks like this is more complicated and needs better differentiation why a page is not accessible. If rootline is hidden, I think a 404 error should be evoked, not 403. But e.g. if FE user is required, we should still give 403. I will check if other issues and / or patches open. Probably best to handle this separately. -
core-ci voted on patch set 3 V +1 03/08/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75349
-
Sybille Peters commented on patch set 3 03/09/25, 08:22
Reply
Set this to "Unresolved". Even if we do not use this patch, I would like to clarify why the if was there, see line 105 in PreviewSimulator of previous patch: if (!(bool)($pageInfo['extendToSubpages'] ?? false)) { https://review.typo3.org/c/Packages/TYPO3.CMS/+/79656/6/typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php#93 From my understanding it makes no sense to query extendToSubpages of current patch in general and in that context. Can anyone help to understand? Can the if be removed? -
Benni Mack commented on patch set 3 03/25/25, 21:06
Reply
this is correct, we do not need to evaluate extendToSubpages on the current page. The correct solution should reside in RecordAccessVoter and we should use this everywhere. -
Benni Mack commented on patch set 3 03/25/25, 21:07
I think this patch solves the same issue https://review.typo3.org/c/Packages/TYPO3.CMS/+/84998 - and fits what I wanted to say. -
Sybille Peters commented on patch set 3 04/06/25, 07:00
Reply
The other patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/84998 does not remove checking the extedToSubpages of the current page: if (!(bool)($pageInfo['extendToSubpages'] ?? false)) { Shouldn't that be removed in any case? -
Benni Mack commented on patch set 3 04/07/25, 13:34
Reply
you are right, I've found the relevant changes in this regard: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74499 I find it interesting that the same check was added in the BackendUtility::ADMCMD_previewCmds() in https://review.typo3.org/c/Packages/TYPO3.CMS/+/68731 a) we need to have both places adapted, and b) we need to have tests in place for this -
Benni Mack commented on patch set 4
V +104/10/25, 22:41Published edit on patch set 3. -
Benni Mack updated the commit message in patch set 5 04/10/25, 22:42
-
Benni Mack voted on patch set 5 CR +1 V +1 04/10/25, 22:42
-
core-ci voted on patch set 4 V +1 04/10/25, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77479
-
core-ci voted on patch set 5 V +1 04/10/25, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77480
-
Stefan Bürk updated the commit message in patch set 6
CR +1V +104/11/25, 09:14 -
core-ci voted on patch set 6 V +1 04/11/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77509
-
Benni Mack voted on patch set 6 CR +1 V +1 04/11/25, 09:25
-
Stefan Bürk voted on patch set 6 CR +2 V +2 04/11/25, 11:36
-
Stefan Bürk merged patch set 7 04/11/25, 11:59