Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
88541[BUGFIX] Invoke correct 404 / 403 error action
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/88541/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/88541/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Domain/Access/RecordAccessGrantedEvent.php+53 −0
- typo3/sysext/core/Classes/Domain/Access/RecordAccessVoter.php+49 −1
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+2 −0
- typo3/sysext/frontend/Classes/Page/PageInformationFactory.php3+22 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+35 −16
Review log 1626
Show 1 earlier messages
-
Sybille Peters uploaded patch set 1 03/09/25, 09:59
-
Sybille Peters commented on patch set 1 03/09/25, 10:02
-
Sybille Peters commented on patch set 1 03/09/25, 10:03
PageInformationFactory.php:460UnresolvedShould we really use ROOTLINE_BROKEN broken here? -
core-ci voted on patch set 1 V -1 03/09/25, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75369
-
Sybille Peters uploaded patch set 2
V -103/09/25, 12:33 -
Sybille Peters updated the commit message in patch set 3 03/09/25, 12:37
-
core-ci voted on patch set 2 V -1 03/09/25, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75373
-
core-ci voted on patch set 3 V -1 03/09/25, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75374
-
Sybille Peters updated the commit message in patch set 4
V -103/11/26, 19:13 -
Sybille Peters updated the commit message in patch set 5 03/11/26, 19:13
-
Sybille Peters updated the commit message in patch set 6 03/11/26, 19:13
-
core-ci voted on patch set 4 V -1 03/11/26, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97773
-
core-ci voted on patch set 5 V -1 03/11/26, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97774
-
core-ci voted on patch set 6 V -1 03/11/26, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97775
-
Sybille Peters uploaded patch set 7
V -103/11/26, 19:29 -
Sybille Peters updated the commit message in patch set 8 03/11/26, 19:31
-
core-ci voted on patch set 7 V -1 03/11/26, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97776
-
core-ci voted on patch set 8 V -1 03/11/26, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97778
-
Andreas Kienast commented on patch set 8 03/12/26, 05:52
The file `typo3/install.php` does not exists anymore, please remove it from your patch. -
Sybille Peters uploaded patch set 9
V -103/12/26, 10:34 -
Sybille Peters commented on patch set 9 03/12/26, 10:34
Reply
Done -
core-ci voted on patch set 9 V -1 03/12/26, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97814
-
Stefan Bürk commented on patch set 9 03/12/26, 11:40
PageInformationFactory.php:503Exception code is duplicate. Should be either a new exception code (timestamp) or the logic needs to change to use one exception throw/code with different messages/responses. Because this changes the logic and introducing other behaviour I'd strive for a new exception code here. -
Sybille Peters uploaded patch set 10
V -103/12/26, 14:19 -
Sybille Peters commented on patch set 9 03/12/26, 14:20
PageInformationFactory.php:503ReplyYes, this was also reprimanded by CI: Build/Scripts/runTests.sh -s checkIntegrityPhp -p 8.2 https://git.typo3.org/typo3/CI/cms/-/jobs/5434806 How to I get a new exception code? I just used the current timestamp. Seems reasonable. -
core-ci voted on patch set 10 V -1 03/12/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97833
Unresolved