Review main Abandoned Breaking

88543[!!!][TASK] Sign extbase __identity field value with HMAC

Torben Hansen CR 0 V 0 Normal +114 −28 updated 11/15/25, 13:10

Commit message

When a persisted extbase object is used in the `object`
attribute of the fluid `f:form` ViewHelper, a hidden
field named `tx_extension_pluginname[object][__identity]`
is rendered to the form. The field value contains the
unique identifier of the extbase object, which is used
in the `PersistentObjectConverter` to fetch the object
from the persistence layer.

Since the field value is not signed, it is possible
to manipulate the field value and thereby update
persisted objects, which the current user may not
have access to. The TYPO3 Security Guidelines
describe this behavior and recommend extension
developers to implement a custom access check for
this scenario. Recent extension security
vulnerabilities however revealed, that extension
developers may not be aware of the recommendation.

In order to prevent manipulation of the `__identity`
field value, the field value now contains a HMAC appended
string (uid + HMAC), which is evaluated by the extbase
property mapper. In case the HMAC evaluation fails, an
exception is thrown.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 10

Review log 2129

Show 24 earlier messages
  1. Torben Hansen uploaded patch set 1 03/09/25, 13:43

  2. Torben Hansen uploaded patch set 2 03/09/25, 13:46

  3. core-ci voted on patch set 1 V -1 03/09/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75375

  4. core-ci voted on patch set 2 V +1 03/09/25, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75376

  1. Garvin Hicking commented on patch set 2 03/09/25, 14:19

    PropertyMapper.php:127

    ```suggestion 'The __identity property of the source data is not valid. Ensure the given value is appended with a valid HMAC.', ```

    PersistentObjectConverterTest.php:122

    ```suggestion $this->expectExceptionMessage('The __identity property of the source data is not valid. Ensure the given value is appended with a valid HMAC.'); ```
  2. Torben Hansen uploaded patch set 3 V +1 03/09/25, 17:39

  3. Torben Hansen commented on patch set 2 03/09/25, 17:39

    PropertyMapper.php:127 Reply

    Done

    PersistentObjectConverterTest.php:122 Reply

    Done
  4. core-ci voted on patch set 3 V +1 03/09/25, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75377

  5. Mathias Brodala commented on patch set 3 03/10/25, 08:02

    PropertyMapper.php:128

    Please also forward the original exception as 3rd argument here.
  6. Helmut Hummel commented on patch set 3 CR -1 03/10/25, 15:27

    I added some concerns to the forge ticket, why I think it is not a good idea to do this.
  7. Elias Häußler uploaded patch set 4 CR -1 V +1 06/25/25, 09:52

  8. core-ci voted on patch set 4 V +1 06/25/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80836

  9. Elias Häußler uploaded patch set 5 V +1 06/26/25, 09:36

  10. Elias Häußler commented on patch set 5 06/26/25, 09:37

    PropertyMapper.php:128 Reply

    Done
  11. core-ci voted on patch set 5 V +1 06/26/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80970

  12. Torben Hansen uploaded patch set 6 V +1 06/26/25, 18:45

  13. core-ci voted on patch set 6 V +1 06/26/25, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81012

  14. Simon Schaufelberger commented on patch set 6 06/30/25, 07:55

    Breaking-106345-SignExtbase__identityFieldValueWithHMAC.rst:21

    space missing before does
  15. Torben Hansen uploaded patch set 7 V +1 07/04/25, 06:31

  16. Torben Hansen commented on patch set 6 07/04/25, 06:31

    Breaking-106345-SignExtbase__identityFieldValueWithHMAC.rst:21 Reply

    Done
  17. core-ci voted on patch set 7 V +1 07/04/25, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81308

  18. Simon Schaufelberger voted on patch set 7 CR +1 07/04/25, 08:38

  19. Torben Hansen marked it work in progress 07/07/25, 12:59

  20. Torben Hansen uploaded patch set 8 CR +1 V +1 11/12/25, 16:35

  21. core-ci voted on patch set 8 V +1 11/12/25, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89371

  22. Torben Hansen marked it ready for review 11/13/25, 17:01

  23. Christian Kuhn commented on patch set 8 11/14/25, 03:41

    Unresolved

    it looks as if there are still some not answered conception questions in the issue. is especially the last remark from helmut still relevant?

    InvalidIdentityException.php:22 Unresolved

    where is that thrown?
  24. Torben Hansen marked it work in progress 11/14/25, 08:16

  25. Torben Hansen abandoned the change 11/15/25, 13:10

    Patch is abandoned, because HMACs can be reused due to Extbase GET/POST merging in context of the same object. Access checks on before every extbase action (#107826) call could be a solution to prevent reading/modification of persisted objects on a user basis.