88543[!!!][TASK] Sign extbase __identity field value with HMAC
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106345-SignExtbase__identityFieldValueWithHMAC.rst2new+38 −0
- typo3/sysext/extbase/Classes/Property/Exception/InvalidIdentityException.php1new+22 −0
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php4+16 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/BlogPostEditingControllerTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/PersistentObjectConverterTest.php2+15 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+0 −7
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+4 −4
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+2 −5
Review log 2129
Show 24 earlier messages
-
Torben Hansen uploaded patch set 1 03/09/25, 13:43
-
Torben Hansen uploaded patch set 2 03/09/25, 13:46
-
core-ci voted on patch set 1 V -1 03/09/25, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75375
-
core-ci voted on patch set 2 V +1 03/09/25, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75376
-
Garvin Hicking commented on patch set 2 03/09/25, 14:19
PersistentObjectConverterTest.php:122```suggestion $this->expectExceptionMessage('The __identity property of the source data is not valid. Ensure the given value is appended with a valid HMAC.'); ``` -
Torben Hansen uploaded patch set 3
V +103/09/25, 17:39 -
Torben Hansen commented on patch set 2 03/09/25, 17:39
PropertyMapper.php:127ReplyDonePersistentObjectConverterTest.php:122ReplyDone -
core-ci voted on patch set 3 V +1 03/09/25, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75377
-
Mathias Brodala commented on patch set 3 03/10/25, 08:02
PropertyMapper.php:128Please also forward the original exception as 3rd argument here. -
Helmut Hummel commented on patch set 3 CR -1 03/10/25, 15:27
I added some concerns to the forge ticket, why I think it is not a good idea to do this. -
Elias Häußler uploaded patch set 4
CR -1V +106/25/25, 09:52 -
core-ci voted on patch set 4 V +1 06/25/25, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80836
-
Elias Häußler uploaded patch set 5
V +106/26/25, 09:36 -
Elias Häußler commented on patch set 5 06/26/25, 09:37
PropertyMapper.php:128ReplyDone -
core-ci voted on patch set 5 V +1 06/26/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80970
-
Torben Hansen uploaded patch set 6
V +106/26/25, 18:45 -
core-ci voted on patch set 6 V +1 06/26/25, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81012
-
Simon Schaufelberger commented on patch set 6 06/30/25, 07:55
Breaking-106345-SignExtbase__identityFieldValueWithHMAC.rst:21space missing before does -
Torben Hansen uploaded patch set 7
V +107/04/25, 06:31 -
Torben Hansen commented on patch set 6 07/04/25, 06:31
Breaking-106345-SignExtbase__identityFieldValueWithHMAC.rst:21ReplyDone -
core-ci voted on patch set 7 V +1 07/04/25, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81308
-
Simon Schaufelberger voted on patch set 7 CR +1 07/04/25, 08:38
-
Torben Hansen marked it work in progress 07/07/25, 12:59
-
Torben Hansen uploaded patch set 8
CR +1V +111/12/25, 16:35 -
core-ci voted on patch set 8 V +1 11/12/25, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89371
-
Torben Hansen marked it ready for review 11/13/25, 17:01
-
Christian Kuhn commented on patch set 8 11/14/25, 03:41
Unresolved
it looks as if there are still some not answered conception questions in the issue. is especially the last remark from helmut still relevant?InvalidIdentityException.php:22Unresolvedwhere is that thrown? -
Torben Hansen marked it work in progress 11/14/25, 08:16
-
Torben Hansen abandoned the change 11/15/25, 13:10
Patch is abandoned, because HMACs can be reused due to Extbase GET/POST merging in context of the same object. Access checks on before every extbase action (#107826) call could be a solution to prevent reading/modification of persisted objects on a user basis.
PropertyMapper.php:127