Review 13.4 Merged

88546[BUGFIX] Workspaces: calculate paging on correct data structure

Andreas Kienast CR +2 V +2 Easy +13 −8 updated 03/10/25, 10:35

Commit message

The method `GridService->calculateStartWithCollections()` relies on
`$this->dataArray` having numeric indices, which is not the case at this
point. The method is called by `GridService->getDataArray()`, which takes
care of this, unfortunately too late.

The key conversion is now done as the beginning of the method, fixing
the pagination.

As a drive-by fix, the pagination component is now properly rendered
after filling the workspace table with new data.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 03/10/25, 10:05

  2. core-ci voted on patch set 1 V +1 03/10/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75398

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 03/10/25, 10:35

  4. Andreas Kienast merged patch set 2 03/10/25, 10:35