Review 12.4 Merged

88547[BUGFIX] Workspaces: calculate paging on correct data structure

Andreas Kienast CR +2 V +2 Easy +5 −4 updated 03/10/25, 10:35

Commit message

The method `GridService->calculateStartWithCollections()` relies on
`$this->dataArray` having numeric indices, which is not the case at this
point. The method is called by `GridService->getDataArray()`, which takes
care of this, unfortunately too late.

The key conversion is now done as the beginning of the method, fixing
the pagination.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Andreas Kienast uploaded patch set 1 03/10/25, 10:08

  2. Andreas Kienast updated the commit message in patch set 2 03/10/25, 10:10

  3. core-ci voted on patch set 1 V +1 03/10/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75399

  4. core-ci voted on patch set 2 V +1 03/10/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75400

  5. Andreas Kienast voted on patch set 2 CR +2 V +2 03/10/25, 10:35

  6. Andreas Kienast merged patch set 3 03/10/25, 10:35