Review 12.4 Merged

88554[TASK] Improve description of SYS|reverseProxyHeaderMultiValue

Benni Mack CR +2 V +2 Easy +2 −2 updated 03/10/25, 12:17

Commit message

The word part “Multi” in `reverseProxyHeaderMultiValue` implies that
the setting of this option would only be necessary if the
`X-Forwarded-For` header contains multiple IP addresses. However, in
the default case `none`, the header is not evaluated at all, even if
it only contains one IP address.

This change clarifies this by updating the description of
`reverseProxyHeaderMultiValue` (and removing the wrong part “if more
than one is found.”) and adding a corresponding note to reverseProxyIP.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 03/10/25, 12:08

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 03/10/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75412

  3. Benni Mack voted on patch set 1 CR +2 V +2 03/10/25, 12:17

  4. Benni Mack merged patch set 2 03/10/25, 12:17