Review main Merged

88555[DOCS] Move extended Fluid cObject examples into Fluid Reference

Lina Wolf CR +2 V +2 Easy +1 −46 updated 03/13/25, 20:46

Commit message

The example section was moved into the ViewHelper Reference and
improved with https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/pull/92

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Lina Wolf uploaded patch set 1 03/10/25, 12:19

  2. core-ci voted on patch set 1 V +1 03/10/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75415

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 03/10/25, 12:31

  4. Garvin Hicking commented on patch set 1 03/10/25, 12:49

    Hm, I kind of like we have these docs inlined in the viewhelpers. If we change that, when do we do this, and should it maybe applied globally instead of just for one VH?
  5. Lina Wolf commented on patch set 1 03/10/25, 13:17

    Reply

    Yes the plan is to do this for all viewhelpers, absolutely. But as always it is wise to try it out for one instead of applying it all over right away. To get rst syntax right within a docomment is troublesome, the IDEs dont display it correctly, it is hard for ppl to contribute to the examples etc. Plan is to leave the basic descriptions with the viewhelpers and they are also still displayed automatically in the reference. However we would like to move the examples with code blocks etc into the reference. See according changes here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/pull/92/files
  6. Lina Wolf updated the commit message in patch set 2 CR +1 V +1 03/10/25, 13:18

  7. core-ci voted on patch set 2 V +1 03/10/25, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75417

  8. Garvin Hicking commented on patch set 2 V +1 03/10/25, 13:45

    Reply

    Thanks! I understand, I'll check back with the if there is any feedback on this change!l
  9. Lina Wolf commented on patch set 2 03/10/25, 13:57

    I am working on applying the changes to all viewhelpers in the core in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88557 but there are many
  10. Simon Praetorius voted on patch set 2 CR +1 V +1 03/12/25, 11:42

  11. Georg Ringer voted on patch set 2 CR +2 V +2 03/13/25, 20:46

  12. Georg Ringer merged patch set 3 03/13/25, 20:46