88557[DOCS] Unify VH descriptions, move examples to Fluid Reference
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 105
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+5 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+5 −1
- typo3/sysext/backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php+8 −1
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php+6 −1
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/IfHasDropdownViewHelper.php+9 −1
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php+6 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+6 −15
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+7 −30
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+5 −33
- typo3/sysext/backend/Classes/ViewHelpers/LanguageColumnViewHelper.php+10 −0
- typo3/sysext/backend/Classes/ViewHelpers/LoginLogoViewHelper.php+10 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+7 −14
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+4 −31
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+5 −1
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+5 −1
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+5 −1
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+10 −1
- typo3/sysext/beuser/Classes/ViewHelpers/IsArrayViewHelper.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/MfaStatusViewHelper.php+5 −1
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+5 −3
Show 85 more files
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+5 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+5 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+4 −13
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+5 −13
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+4 −25
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+4 −17
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php+7 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/InstallationStateCssClassViewHelper.php+5 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+5 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+4 −17
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+4 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php+10 −13
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php2+13 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php2+14 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php2+12 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php2+13 −39
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+5 −30
- typo3/sysext/fluid/Classes/ViewHelpers/Be/LinkViewHelper.php+5 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php2+6 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php2+5 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php2+4 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php2+17 −32
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php2+5 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.php+10 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.php+16 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+14 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php2+8 −23
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php2+6 −39
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php4+11 −52
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php2+5 −13
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php2+5 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php2+6 −41
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php2+6 −69
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php2+5 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php2+7 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php2+6 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadDeleteCheckboxViewHelper.php2+5 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadViewHelper.php2+6 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php2+26 −43
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php2+6 −34
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php2+8 −61
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php2+8 −52
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php2+9 −95
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php2+8 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php2+8 −25
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php2+16 −84
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php2+6 −34
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php2+6 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php2+6 −41
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php2+5 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php2+5 −32
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php2+5 −41
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php2+5 −60
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php2+10 −24
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php2+12 −31
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php2+12 −45
- typo3/sysext/fluid/Classes/ViewHelpers/Security/NonceViewHelper.php3+9 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php2+7 −22
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php2+6 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php2+7 −21
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php2+9 −73
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php2+5 −35
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php4+9 −43
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php2+5 −30
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+7 −3
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php2+16 −27
- typo3/sysext/fluid/Classes/ViewHelpers/FeatureViewHelper.php2+13 −25
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php2+16 −69
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php2+8 −30
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php2+8 −86
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php2+10 −37
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php2+10 −78
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+4 −10
- typo3/sysext/impexp/Classes/ViewHelpers/InArrayViewHelper.php+10 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+6 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+6 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+6 −0
- typo3/sysext/indexed_search/Classes/ViewHelpers/SearchResult/RatingViewHelper.php+9 −0
- typo3/sysext/install/Classes/ViewHelpers/Format/NoSpaceViewHelper.php+5 −1
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+5 −1
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+5 −1
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageRecordViewHelper.php+6 −2
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php+3 −10
- typo3/sysext/styleguide/Classes/ViewHelpers/ColorSchemeViewHelper.php+3 −4
- typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php+3 −10
Review log 4354
Show 2329 earlier messages
-
Lina Wolf uploaded patch set 1 03/10/25, 13:55
-
Lina Wolf marked it work in progress 03/10/25, 13:56
-
core-ci voted on patch set 1 V -1 03/10/25, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75419
-
Lina Wolf uploaded patch set 2
V -103/12/25, 13:34 -
Lina Wolf marked it ready for review 03/12/25, 13:36
-
Lina Wolf updated the commit message in patch set 3 03/12/25, 13:37
-
core-ci voted on patch set 2 V +1 03/12/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75511
-
core-ci voted on patch set 3 V +1 03/12/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75512
-
Georg Ringer voted on patch set 3 CR +1 V +1 03/13/25, 20:59
-
Garvin Hicking commented on patch set 3 03/13/25, 21:01
backport note: we should probably attach @13.4 to the permalink URL, right @112@linawolf.de ? Is this patch finished from your side? -
Lina Wolf commented on patch set 3 03/15/25, 16:08
Reply
The patch is finished. I would not suggest to edit the comments for back versions, Development is usually done in in main versions so only there developers will click the links directly from the code. Changed comments would just increase the likely hood of conflicts during backport -
Benni Mack commented on patch set 3 CR -1 03/17/25, 10:58
Reply
I do not understand why this change should be merged into main & 12.4 but NOT in 13.4. Can you elaborate this? -
Lina Wolf updated the commit message in patch set 4
CR +1V +103/17/25, 11:10 -
Lina Wolf commented on patch set 4 03/17/25, 11:11
Reply
duh, was living in the past. 13.4 of course -
core-ci voted on patch set 4 V +1 03/17/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75708
-
Jörg Bösche voted on patch set 4 CR +1 03/24/25, 09:00
-
Garvin Hicking commented on patch set 4 CR -1 03/28/25, 13:32
I see two problems with this: 1. Some Viewhelpers have unneeded examples (be.pageInfo), there it's ok to remove examples. But for others I would now have to lookup a URL outside my IDE to see usage info - I always found it helpful to see inline basic examples. So maybe we could leave some simple examples in?! 2. What do we do for patches that change viewhelpers? Must contributors create a docs patch explaining this? will it be unexplained until the docs team addresses it? Would it need a Rst entry every time a VH is enhanced with an attribute? I think maybe the easiest way is to keep all current docs and just insert the link. Docs will start to differ in their content, that's the downside. I see no fully ideal variant here. Thoughts? -
Lina Wolf commented on patch set 4 03/29/25, 07:37
Reply
We already had this discussion in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88555. I rolled this out across all Core ViewHelpers on the grounds that you already agreed on the general course. A Fluid ViewHelper (in the TYPO3 Core) can in future just be handled like any other Core change. A short description and definition of all arguments within the class itself. A changelog entry with some examples. Uppon writing the docs we enhance these examples and make them closer to the reality of integrators. This principle works fine for other features as well. If you absolutely want to stay within the Core you can find these examples in the Core Changelog then. Also if you look at the examples in detail you will see that many are outdated. Most of them reflect a Core developers point of view and are hard to understand for integrators. Compare for example https://docs.typo3.org/other/typo3/view-helper-reference/13.4/en-us/Global/FlashMessages.html (written manually) and https://docs.typo3.org/other/typo3/view-helper-reference/12.4/en-us/Global/FlashMessages.html (still from the Core). -
Lina Wolf commented on patch set 4 03/29/25, 07:43
Reply
Done -
Garvin Hicking commented on patch set 4 CR 0 03/29/25, 08:32
Reply
Thanks for the response. I must admit I only understood the full consequences of this when seeing so many useful examples removed. I think if we iterate on this we will achieve a better DX and workflow. i've explicitly now commented where I think we should keep basic examples and what can be easily removed. Of course I can be overruled/overvoted and will not be blocking.ActionMenuItemViewHelper.php:40Let's keep the examples here (without descriptions/text)?ActionMenuViewHelper.php:38keep basic examples, no textPageInfoViewHelper.php:36good to removePagePathViewHelper.php:37good to removePageRendererViewHelper.php:38keep basic examples, no textIfAuthenticatedViewHelper.php:35good to removeIfHasRoleViewHelper.php:35keep basic examples, no textTableListViewHelper.php:52keep this exampleUriViewHelper.php:30keep basic examples, no textDebugViewHelper.php:43keep basic examples, no textFeatureViewHelper.php:37keep basic examples, no textFlashMessagesViewHelper.php:80keep basic examples, no textButtonViewHelper.php:37keep basic examples, no textCheckboxViewHelper.php:42keep basic examples, no textCountrySelectViewHelper.php:37keep basic examples, no textCountrySelectViewHelper.php:69keep this example, less textHiddenViewHelper.php:28keep basic examples, no textPasswordViewHelper.php:28keep basic examples, no textRadioViewHelper.php:42keep basic examples, no textSelectViewHelper.php:33keep basic examples, less textSubmitViewHelper.php:42keep basic examples, no textTextareaViewHelper.php:30keep basic examples, no textTextfieldViewHelper.php:28keep basic examples, no textUploadDeleteCheckboxViewHelper.php:40keep basic examples, no textUploadViewHelper.php:30keep basic examples, no textValidationResultsViewHelper.php:58keep basic example here, no textFormViewHelper.php:62keep basic examples, no text - maybe we need to include all the params for a full exampleBytesViewHelper.php:57keep basic examples, no textCropViewHelper.php:74keep basic examples, no textCurrencyViewHelper.php:44keep basic examples, no textDateViewHelper.php:38keep all basic examples, less textHtmlViewHelper.php:57keep basic examples, no textHtmlentitiesDecodeViewHelper.php:32keep basic examples, no textHtmlentitiesViewHelper.php:24good to removePaddingViewHelper.php:57keep basic examples, no textImageViewHelper.php:40keep all basic examples, less textActionViewHelper.php:35we might want to provide a full argument list example hereEmailViewHelper.php:36imo very self explanatory, good to removeExternalViewHelper.php:25imo self explanatory, good to removeFileViewHelper.php:42keep basic examples, no textPageViewHelper.php:39keeo a "ull argument" example here, no textTypolinkViewHelper.php:76keep basic examples, small text keeping the typolink format descriptionMediaViewHelper.php:65keep basic example, no textHtmlViewHelper.php:34imo self explanatory, good to removeIfAuthenticatedViewHelper.php:28good to removeIfHasRoleViewHelper.php:37keep one example for named and uid role eachNonceViewHelper.php:35keep basic example, no text. also link to CSP docs?HtmlViewHelper.php:34keep basic examples, no textTranslateViewHelper.php:34keeo some basic variants with "key", no textActionViewHelper.php:39keep basic example, no textExternalViewHelper.php:26imo self explanatory, good to removeImageViewHelper.php:61keep basic examples, no textPageViewHelper.php:58keep example with full params, no textResourceViewHelper.php:45keep basic examples with full args, no textResourceViewHelper.php:64keep this sentenceTypolinkViewHelper.php:33maybe add a mention to f:typolinkviewhelper so that all examples can be removed here -
Lina Wolf commented on patch set 4 03/29/25, 08:38
NonceViewHelper.php:35ReplyExtended docs such as a link to CSP docs belong in the documentation in my eyes? -
Lina Wolf marked it work in progress 04/01/25, 11:13
-
Lina Wolf commented on patch set 4 04/01/25, 11:14
Talked to Garvin and He would prefere to keep basic examples. He will make a suggestion, so putting this on WIP for now -
Garvin Hicking commented on patch set 4 04/01/25, 11:18
Reply
Thanks. I've also tried to get a hold of the core team and hear their input on this before I begin to spent much time on this. -
Garvin Hicking uploaded patch set 5
CR +1V +104/09/25, 13:48 -
Garvin Hicking commented on patch set 5 04/09/25, 13:50
This change is ready for review.Reply
We had a 4:1 vote on using this patch, keeping simple examples. See updated patchset.Reply
DoneActionMenuItemViewHelper.php:40ReplyDoneActionMenuViewHelper.php:38ReplyDonePageInfoViewHelper.php:36ReplyDonePagePathViewHelper.php:37ReplyDonePageRendererViewHelper.php:38ReplyDoneIfAuthenticatedViewHelper.php:35ReplyDoneIfHasRoleViewHelper.php:35ReplyDoneTableListViewHelper.php:52ReplyDoneUriViewHelper.php:30ReplyDoneDebugViewHelper.php:43ReplyDoneFeatureViewHelper.php:37ReplyDoneFlashMessagesViewHelper.php:80ReplyDoneButtonViewHelper.php:37ReplyDoneCheckboxViewHelper.php:42ReplyDoneCountrySelectViewHelper.php:37ReplyDoneCountrySelectViewHelper.php:69ReplyDoneHiddenViewHelper.php:28ReplyDonePasswordViewHelper.php:28ReplyDoneRadioViewHelper.php:42ReplyDoneSelectViewHelper.php:33ReplyDoneSubmitViewHelper.php:42ReplyDoneTextareaViewHelper.php:30ReplyDoneTextfieldViewHelper.php:28ReplyDoneUploadDeleteCheckboxViewHelper.php:40ReplyDoneUploadViewHelper.php:30ReplyDoneValidationResultsViewHelper.php:58ReplyDoneFormViewHelper.php:62ReplyDoneBytesViewHelper.php:57ReplyDoneCropViewHelper.php:74ReplyDoneCurrencyViewHelper.php:44ReplyDoneDateViewHelper.php:38ReplyDoneHtmlViewHelper.php:57ReplyDoneHtmlentitiesDecodeViewHelper.php:32ReplyDoneHtmlentitiesViewHelper.php:24ReplyDonePaddingViewHelper.php:57ReplyDoneImageViewHelper.php:40ReplyDoneActionViewHelper.php:35ReplyDoneEmailViewHelper.php:36ReplyDoneExternalViewHelper.php:25ReplyDoneFileViewHelper.php:42ReplyDonePageViewHelper.php:39ReplyDoneTypolinkViewHelper.php:76ReplyDoneMediaViewHelper.php:65ReplyDoneHtmlViewHelper.php:34ReplyDoneIfAuthenticatedViewHelper.php:28ReplyDoneIfHasRoleViewHelper.php:37ReplyDoneNonceViewHelper.php:35ReplyDoneHtmlViewHelper.php:34ReplyDoneTranslateViewHelper.php:34ReplyDoneActionViewHelper.php:39ReplyDoneExternalViewHelper.php:26ReplyDoneImageViewHelper.php:61ReplyDonePageViewHelper.php:58ReplyDoneResourceViewHelper.php:45ReplyDoneResourceViewHelper.php:64ReplyDoneTypolinkViewHelper.php:33ReplyDone -
core-ci voted on patch set 5 V +1 04/09/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77284
-
Garvin Hicking uploaded patch set 6
V +104/09/25, 15:00 -
core-ci voted on patch set 6 V +1 04/09/25, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77292
-
Christian Kuhn voted on patch set 6 CR +1 V +1 04/09/25, 15:47
-
Garvin Hicking commented on patch set 6 CR -1 04/09/25, 15:51
(Just setting a blocker for merging this, I need/want Linas approval for this before rolling this out, mostly to be sure that the changes will have no negative impact on the Fluid reference rendering or the API docs) -
Garvin Hicking commented on patch set 7
CR +1V +104/10/25, 07:21Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 04/10/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77393
-
Lina Wolf commented on patch set 7 CR +1 V +1 04/10/25, 07:32
From the ViewHelper Reference and API docs point of view this is a good solution -
Garvin Hicking commented on patch set 7 CR -1 04/10/25, 07:59
doing the other VHs too now -
Garvin Hicking uploaded patch set 8
CR +1V +104/10/25, 08:26 -
core-ci voted on patch set 8 V +1 04/10/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77403
-
Lina Wolf voted on patch set 8 CR +1 V +1 04/10/25, 13:58
-
Christian Kuhn voted on patch set 8 CR +1 V +1 04/10/25, 18:08
-
Garvin Hicking voted on patch set 8 CR +2 04/10/25, 18:09
-
Garvin Hicking voted on patch set 8 CR +1 04/11/25, 06:19
-
Garvin Hicking rebased onto patch set 9
CR +1V +104/11/25, 15:41The following files contain Git conflicts: * typo3/sysext/redirects/Classes/ViewHelpers/TargetPageIdViewHelper.php -
Garvin Hicking commented on patch set 10 04/11/25, 15:42
Published edit on patch set 9. -
Garvin Hicking marked it ready for review 04/11/25, 15:43
-
core-ci voted on patch set 10 V +1 04/11/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77555
-
core-ci voted on patch set 9 V -1 04/11/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77554
-
Garvin Hicking commented on patch set 10 CR -1 04/11/25, 16:04
needs to adapt the renamed TargetPageRecordVH from TargetPageIdVH earlier now due to https://review.typo3.org/89045 -
Garvin Hicking uploaded patch set 11
CR -1V +104/15/25, 18:36 -
Garvin Hicking commented on patch set 11 CR +1 V +1 04/15/25, 18:38
Reply
Done -
core-ci voted on patch set 11 V +1 04/15/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77774
-
Christian Kuhn voted on patch set 11 CR +1 V +1 04/15/25, 19:08
-
Garvin Hicking voted on patch set 11 CR +2 V +2 04/15/25, 19:34
-
Garvin Hicking merged patch set 12 04/15/25, 19:34