Review main Merged

88558[BUGFIX] Ignore non-viewable pages as slug candidates

Sascha Egerer CR +2 V +2 Normal +48 −4 updated 11/13/26, 10:35

Commit message

Pages of a non-viewable page type, such as spacers and folders,
cannot be rendered in the frontend, but their slugs were still
considered when resolving an URL. If such a page shares its slug
with a regular page, the URL could resolve to the folder and
result in a "page not found" error.

The page types marked as "isViewable" => false in TCA are now
excluded from the slug candidates. In addition, candidates are
sorted by uid as the last criterion, so pages sharing a slug
resolve to the same page on all database platforms.

Requesting the slug of a spacer or folder still results in a
404 response, now raised during routing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2027

Show 12 earlier messages
  1. Sascha Egerer uploaded patch set 1 03/10/25, 14:14

  2. core-ci voted on patch set 1 V -1 03/10/25, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75420

  1. Andreas Kienast updated the commit message in patch set 2 V -1 03/10/25, 15:07

  2. Andreas Kienast commented on patch set 2 03/10/25, 15:08

    11.5 does not receive public support anymore, therefore I've removed it from the `Releases` line.
  3. core-ci voted on patch set 2 V -1 03/10/25, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75425

  4. Georg Ringer commented on patch set 2 03/11/25, 20:17

    PageSlugCandidateProvider.php:213

    those should be strings, not integers, IMHO
  5. Georg Ringer commented on patch set 2 03/11/25, 20:20

    PageSlugCandidateProvider.php:213 Reply

    sry, bs ^^
  6. Sascha Egerer commented on patch set 2 03/11/25, 20:53

    I don't have time to look at the tests yet but I find it very strange that they fail. The test searches for “The requested page does not exist!” and the markup says <p class=“typo3-error-page-message”>The page did not exist or was inaccessible. Reason: The requested page does not exist</p>\n The “!” is simply missing. I wonder why this is occurring now with this fix - are there two different 404 handlings and now you run into the other one? I am confused. I'll try to check it soon.
  7. Georg Ringer uploaded patch set 3 V -1 03/12/25, 19:23

  8. core-ci voted on patch set 3 V +1 03/12/25, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75525

  9. Benni Mack commented on patch set 3 CR -1 03/12/25, 20:50

    will check
  10. Georg Ringer rebased onto patch set 4 CR -1 V +1 04/08/25, 12:25

  11. Benni Mack commented on patch set 4 04/08/25, 12:28

    I just (still) wonder how you manage to get two pages with the same slug?... don't get me wrong but if - we take the issue and have to pages of default doktype with "/foo" - we will have the same problem again. With Core code this is IMHO just not possible, and creating links to such pages is also not possible. When calling URLs to such pages such as /storage-folder/ we already have a 404... On the other side, we want to allow certain doktypes to have empty slugs. Also including a flexibility of "Non-linkable doktypes" - both are other issues on forge, which I am happy to tackle in v14.
  12. core-ci voted on patch set 4 V +1 04/08/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77208

  13. Sascha Egerer commented on patch set 4 04/17/25, 10:03

    Reply

    > I just (still) wonder how you manage to get two pages with the same slug? I think this was done by the "RealURL" to "slug" migration. The tricky thing is that the issue is somehow "hidden" and there is no information that it does exist. For sure we can argue this is an edge case and duplicated slugs can never happen but then there should maybe be some kind of error report for this?
  14. Benni Mack wrote 04/21/26, 15:00

    Removed reviewer Benni Mack.
  15. Benni Mack updated the commit message in patch set 5 V +1 04/22/26, 06:27

  16. core-ci voted on patch set 5 V -1 04/22/26, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100707

  17. Benni Mack uploaded patch set 6 V -1 11/12/26, 20:46

  18. Benni Mack updated the commit message in patch set 7 11/12/26, 20:53

  19. Benni Mack commented on patch set 7 CR +1 V +1 11/12/26, 20:53

    Reply

    I now did an order by - if we need a report, we can add this as a separate patch.
  20. core-ci voted on patch set 6 V +1 11/12/26, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114230

  21. Garvin Hicking voted on patch set 7 CR +1 V +1 11/12/26, 21:02

  22. core-ci voted on patch set 7 V +1 11/12/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114233

  23. Oliver Klee voted on patch set 7 V +1 11/12/26, 22:33

  24. Benni Mack voted on patch set 7 CR +2 V +2 11/13/26, 10:35

  25. Benni Mack merged patch set 8 11/13/26, 10:35