88561[TASK] Introduce "settings" Data Processor for FLUIDTEMPLATE
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106354-IntroduceSettingsDataProcessorForFLUIDTEMPLATE.rstnew+72 −0
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+5 −1
- typo3/sysext/frontend/Classes/DataProcessing/SettingsProcessor.phpnew+71 −0
- typo3/sysext/frontend/Configuration/Services.yaml+4 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/DataSet/SettingsProcessor.csvnew+3 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/DataSet/SettingsProcessorWithPage.csvnew+4 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/DataSet/SettingsProcessorWithSite.csvnew+4 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/SettingsProcessorTest.phpnew+76 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Settings/config.yamlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Settings/settings.definitions.yamlnew+15 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Settings/setup.typoscriptnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/Resources/Private/Pages/Default.htmlnew+7 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/composer.jsonnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_site_settings/ext_emconf.phpnew+22 −0
Review log 1216
-
Lina Wolf uploaded patch set 1 03/10/25, 16:03
-
Lina Wolf marked it work in progress 03/10/25, 16:03
-
core-ci voted on patch set 1 V -1 03/10/25, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75428
-
Lina Wolf uploaded patch set 2
V -103/10/25, 18:24 -
Lina Wolf uploaded patch set 3 03/10/25, 18:31
-
core-ci voted on patch set 2 V +1 03/10/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75435
-
core-ci voted on patch set 3 V +1 03/10/25, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75436
-
Lina Wolf uploaded patch set 4
V +103/11/25, 15:39 -
Lina Wolf marked it ready for review 03/11/25, 15:39
-
core-ci voted on patch set 4 V +1 03/11/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75484
-
Benni Mack commented on patch set 4 03/28/25, 23:35
That's a completely new feature. I personally think we could a) and add it as Feature for v14.0 b) ship it as part of an extension "early-adopter-v14" :) - so people can use some features for v14 right now. -
Georg Ringer commented on patch set 4 03/29/25, 05:45
Don't like the name pagesettings much, is site settings better? -
Lina Wolf commented on patch set 4 03/29/25, 05:53
Reply
Well the difference is that the settings in the site (site settings) are not enriched by TypoScript constants. Therefore the pure site settings are the same across the whole site while the settings enriched with TypoScript constants can differ from page to page -
Benni Mack marked it work in progress 04/11/25, 20:40
-
Benni Mack commented on patch set 4 04/11/25, 20:40
Marking as WIP - awaiting feedback from @ben@bnf.dev -
Lina Wolf abandoned the change 10/22/25, 13:27
Will be solved in another way