Review 13.4 Merged

88569[BUGFIX] Correctly disable output buffering before a command is run

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 03/11/25, 08:28

Commit message

TYPO3 Bootstrap currently always starts output buffering,
even on CLI. The latter is quite confusing
as it delays console output until the process is ended.

Symfony ConsoleOutput is not designed to work with this.

It can also lead to excessive memory consumption
for commands with heavy output that do not explicitly
end the output buffering before sending output.

Last but not least, the documented reason
for starting output buffering does not exist on CLI
(ensure AJAX output not corrupted with accidental output).

For the least impact, make sure the output buffering is
stopped before a command is run by using the correct PHP function
for that.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 03/11/25, 08:16

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/11/25, 08:16

  3. core-ci voted on patch set 1 V +1 03/11/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75461

  4. Benjamin Franzke merged patch set 2 03/11/25, 08:28