Review main Merged

88573[BUGFIX] Fix pagets config retrieval from site sets

Benjamin Franzke CR +2 V +2 Normal +97 −15 updated 03/12/25, 06:56

Commit message

With #106164 site set paths were rebased to use EXT-paths instead of
absolute paths, but the PageTS configuration loader was missed to be
adapted to resolve the virtual extension path to a file system
path before trying to use the file.

Also ensure that we use `EXT:{extensionKey}/` instead of
`EXT:{packageName}/´ (composer package name based) to avoid conflicts
between vendor names and extension keys during path resolution.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Kevin Appelt +1
    • Albrecht Köhnlein +1
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 1217

  1. Benjamin Franzke uploaded patch set 1 03/11/25, 12:06

  2. core-ci voted on patch set 1 V +1 03/11/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75476

  3. Kevin Appelt commented on patch set 1 V +1 03/11/25, 12:14

    Can confirm that the patch resolves the issue that pagets config does not get loaded from site sets. Applying the patch results in loaded site set pagets config.
  4. Benjamin Franzke uploaded patch set 2 V +1 03/11/25, 12:18

  5. core-ci voted on patch set 2 V -1 03/11/25, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75477

  6. Benjamin Franzke uploaded patch set 3 V -1 03/11/25, 13:07

  7. core-ci voted on patch set 3 V -1 03/11/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75479

  8. Benjamin Franzke uploaded patch set 4 V -1 03/11/25, 13:21

  9. core-ci voted on patch set 4 V +1 03/11/25, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75481

  10. Benjamin Franzke uploaded patch set 5 V +1 03/11/25, 13:48

  11. core-ci voted on patch set 5 V +1 03/11/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75482

  12. Albrecht Köhnlein voted on patch set 5 V +1 03/11/25, 14:53

  13. Andreas Kienast voted on patch set 5 CR +1 03/11/25, 15:26

  14. Kevin Appelt voted on patch set 5 V +1 03/11/25, 15:36

  15. Georg Ringer voted on patch set 5 CR +1 V +1 03/11/25, 20:09

  16. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/12/25, 06:55

  17. Benjamin Franzke merged patch set 6 03/12/25, 06:56