Review main Merged

88580[BUGFIX] Refine category menu behavior and improve settings ui

Benjamin Kott CR +2 V +2 Hard +268 −110 updated 03/27/25, 07:23

Commit message

The category menu now dynamically adjusts to use available viewport
space and becomes scrollable when necessary. This ensures smoother
interaction with overflowing categories, independent of the document's
flow. On smaller viewports, the category menu is hidden to preserve
usability.

To address the reduced navigation options, the search bar is now
persistent and affixed to the top of the document for better
accessibility and streamlined navigation. Users can now quickly
locate desired settings.

Category icons, when set, are also displayed in the main body, making
section switches more visually noticeable while scrolling. The previous
dots have been replaced with chevrons for a cleaner and more cohesive
look.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1629

Show 24 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/12/25, 15:20

  2. core-ci voted on patch set 1 V +1 03/12/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75517

  3. Benjamin Kott uploaded patch set 2 V +1 03/13/25, 10:40

  4. core-ci voted on patch set 2 V +1 03/13/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75547

  1. Benjamin Kott uploaded patch set 3 V +1 03/13/25, 13:56

  2. core-ci voted on patch set 3 V +1 03/13/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75550

  3. Benjamin Kott uploaded patch set 4 V +1 03/18/25, 14:37

  4. core-ci voted on patch set 4 V +1 03/18/25, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75781

  5. Benjamin Kott uploaded patch set 5 V +1 03/18/25, 15:09

  6. core-ci voted on patch set 5 V +1 03/18/25, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75783

  7. Benjamin Kott uploaded patch set 6 V +1 03/19/25, 11:03

  8. core-ci voted on patch set 6 V +1 03/19/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75821

  9. Benjamin Kott uploaded patch set 7 V +1 03/19/25, 11:23

  10. core-ci voted on patch set 7 V +1 03/19/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75822

  11. Benjamin Franzke uploaded patch set 8 V +1 03/24/25, 10:37

  12. core-ci voted on patch set 8 V -1 03/24/25, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76137

  13. Benjamin Franzke rebased onto patch set 9 CR +1 V +1 03/24/25, 11:03

  14. core-ci voted on patch set 9 V -1 03/24/25, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76141

  15. Benjamin Franzke rebased onto patch set 10 CR +1 V +1 03/24/25, 12:01

  16. core-ci voted on patch set 10 V +1 03/24/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76147

  17. Benjamin Franzke rebased onto patch set 11 CR +1 V +1 03/25/25, 16:04

  18. core-ci voted on patch set 11 V +1 03/25/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76288

  19. Benjamin Kott uploaded patch set 12 CR +1 V +1 03/26/25, 07:43

  20. core-ci voted on patch set 12 V +1 03/26/25, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76355

  21. Andreas Kienast uploaded patch set 13 V +1 03/26/25, 08:17

  22. Andreas Kienast commented on patch set 13 CR +1 V +1 03/26/25, 08:20

    It seems the scroll spy has one minor issue, but no blocker IMO: I have the introduction package installed. When I edit the site settings for that site and search for "default", I get a filtered set of settings, as expected. When I click the node "Bootstrap Package / Navigation / Main", the document scrolls down, but due to the document height, highlighting in the menu stops at "Bootstrap Package / Cookie Consent".
  23. core-ci voted on patch set 13 V +1 03/26/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76356

  24. Benjamin Franzke voted on patch set 13 CR +2 V +2 03/27/25, 07:13

  25. Benjamin Franzke merged patch set 14 03/27/25, 07:23