88580[BUGFIX] Refine category menu behavior and improve settings ui
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/Sass/component/_settings.scss+98 −44
- Build/Sources/TypeScript/backend/settings/editor.ts+103 −42
- Build/Sources/TypeScript/backend/utility/dom-helper.ts+29 −0
- Build/Sources/TypeScript/backend/color-picker.ts+1 −1
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+7 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Edit.html+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+27 −18
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/dom-helper.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/color-picker.js+1 −1
Review log 1629
Show 24 earlier messages
-
Benjamin Kott uploaded patch set 1 03/12/25, 15:20
-
core-ci voted on patch set 1 V +1 03/12/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75517
-
Benjamin Kott uploaded patch set 2
V +103/13/25, 10:40 -
core-ci voted on patch set 2 V +1 03/13/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75547
-
Benjamin Kott uploaded patch set 3
V +103/13/25, 13:56 -
core-ci voted on patch set 3 V +1 03/13/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75550
-
Benjamin Kott uploaded patch set 4
V +103/18/25, 14:37 -
core-ci voted on patch set 4 V +1 03/18/25, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75781
-
Benjamin Kott uploaded patch set 5
V +103/18/25, 15:09 -
core-ci voted on patch set 5 V +1 03/18/25, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75783
-
Benjamin Kott uploaded patch set 6
V +103/19/25, 11:03 -
core-ci voted on patch set 6 V +1 03/19/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75821
-
Benjamin Kott uploaded patch set 7
V +103/19/25, 11:23 -
core-ci voted on patch set 7 V +1 03/19/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75822
-
Benjamin Franzke uploaded patch set 8
V +103/24/25, 10:37 -
core-ci voted on patch set 8 V -1 03/24/25, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76137
-
Benjamin Franzke rebased onto patch set 9
CR +1V +103/24/25, 11:03 -
core-ci voted on patch set 9 V -1 03/24/25, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76141
-
Benjamin Franzke rebased onto patch set 10
CR +1V +103/24/25, 12:01 -
core-ci voted on patch set 10 V +1 03/24/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76147
-
Benjamin Franzke rebased onto patch set 11
CR +1V +103/25/25, 16:04 -
core-ci voted on patch set 11 V +1 03/25/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76288
-
Benjamin Kott uploaded patch set 12
CR +1V +103/26/25, 07:43 -
core-ci voted on patch set 12 V +1 03/26/25, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76355
-
Andreas Kienast uploaded patch set 13
V +103/26/25, 08:17 -
Andreas Kienast commented on patch set 13 CR +1 V +1 03/26/25, 08:20
It seems the scroll spy has one minor issue, but no blocker IMO: I have the introduction package installed. When I edit the site settings for that site and search for "default", I get a filtered set of settings, as expected. When I click the node "Bootstrap Package / Navigation / Main", the document scrolls down, but due to the document height, highlighting in the menu stops at "Bootstrap Package / Cookie Consent". -
core-ci voted on patch set 13 V +1 03/26/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76356
-
Benjamin Franzke voted on patch set 13 CR +2 V +2 03/27/25, 07:13
-
Benjamin Franzke merged patch set 14 03/27/25, 07:23