Review main Merged

88583[BUGFIX] Check type of criteria used by ::findBy method

Georg Ringer CR +2 V +2 Easy +25 −0 updated 03/31/25, 20:29

Commit message

Check the type to be a string and throw a meaningful
exception if not a string.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Georg Ringer uploaded patch set 1 03/12/25, 19:14

  2. Georg Ringer commented on patch set 1 03/12/25, 19:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/12/25, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75524

  4. Lina Wolf commented on patch set 1 03/13/25, 10:46

    Great! You even wrote a test for this!
  5. Georg Ringer rebased onto patch set 2 V -1 03/30/25, 08:20

  6. core-ci voted on patch set 2 V -1 03/30/25, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76663

  7. Georg Ringer uploaded patch set 3 V -1 03/30/25, 09:07

  8. core-ci voted on patch set 3 V +1 03/30/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76665

  9. Oliver Klee voted on patch set 3 CR +1 03/31/25, 09:07

  10. Oliver Klee voted on patch set 3 V +1 03/31/25, 09:07

  11. Benni Mack voted on patch set 3 CR +1 V +1 03/31/25, 20:26

  12. Georg Ringer voted on patch set 3 CR +2 V +2 03/31/25, 20:29

  13. Georg Ringer merged patch set 4 03/31/25, 20:29