Review main Merged

88584[BUGFIX] Fix timezone offset in scheduler start/end fields

Benjamin Franzke CR +2 V +2 Easy +22 −13 updated 03/17/25, 07:36

Commit message

Also avoid "unsaved changes" modal pops up when closing
task without any changes by formatting the date the same
way as the datetime picker does (using a Z suffix in any case),
as scheduler form makes a diff between all form values to
detect changes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 03/13/25, 10:26

  2. core-ci voted on patch set 1 V +1 03/13/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75546

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 03/14/25, 19:38

    Fixes both issues for me (tested on main)
  4. Georg Ringer voted on patch set 1 CR +1 V +1 03/16/25, 07:16

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 03/16/25, 15:36

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/17/25, 07:31

  7. Benjamin Franzke merged patch set 2 03/17/25, 07:36