Review main Merged

88588[TASK] Remove collapsing docheader and move to scaffold grid

Benjamin Kott CR +2 V +2 Hard +392 −504 updated 03/25/25, 16:03

Commit message

The collapsing docheader was introduced to make more space
available on smaller screens sizes, but always came at the
drawback of moving parts that could lead to a visual
scissor effect.

This effect needed to be accounted for in several parts
of the backend and was not available in every module,
this is an inconsistency we are now removing. We think
it is better to have a consistant ui than a really small
benefit in space consumption with debatable results.

The docheader is now always sticky and kept in it's
position, to make it fell more like an application
with steady elements that you can rely on reaching
always the same way. We are moving the scrollable
part to the body of the module frame. This allows
us to built better optimized interfaces for certain
situations, as the frame is more stable, like in
the forms module.

The backend is moving away from a flexbox implementation
towards a grid system with defined sections of the
backend. This also allows for outside control of grid areas.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 39

Show 19 more files

Review log 2035

Show 510 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/14/25, 08:09

  2. Benjamin Kott uploaded patch set 2 03/14/25, 08:21

  3. core-ci voted on patch set 1 V -1 03/14/25, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75578

  4. core-ci voted on patch set 2 V -1 03/14/25, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75580

  5. Benjamin Kott uploaded patch set 3 V -1 03/14/25, 10:01

  6. core-ci voted on patch set 3 V +1 03/14/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75585

  7. Benjamin Kott uploaded patch set 4 V +1 03/14/25, 15:53

  8. core-ci voted on patch set 4 V -1 03/14/25, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75605

  9. Benjamin Kott uploaded patch set 5 V -1 03/17/25, 11:05

  10. core-ci voted on patch set 5 V +1 03/17/25, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75707

  1. Benjamin Kott uploaded patch set 6 V +1 03/17/25, 15:16

  2. core-ci voted on patch set 6 V +1 03/17/25, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75728

  3. Benjamin Kott uploaded patch set 7 V +1 03/18/25, 11:17

  4. core-ci voted on patch set 7 V +1 03/18/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75774

  5. Benjamin Kott uploaded patch set 8 V +1 03/19/25, 10:00

  6. core-ci voted on patch set 8 V +1 03/19/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75816

  7. Benjamin Kott uploaded patch set 9 V +1 03/19/25, 10:41

  8. core-ci voted on patch set 9 V +1 03/19/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75818

  9. Benjamin Franzke commented on patch set 9 CR +1 03/24/25, 10:17

    _scaffold.scss:104

    Same is in line 79, can thus be dropped.
  10. Benjamin Franzke uploaded patch set 10 CR +1 V +1 03/24/25, 10:30

  11. Benjamin Franzke commented on patch set 10 03/24/25, 10:30

    _scaffold.scss:104 Reply

    Done
  12. core-ci voted on patch set 10 V -1 03/24/25, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76136

  13. Benjamin Franzke uploaded patch set 11 CR +1 V +1 03/24/25, 11:03

  14. core-ci voted on patch set 11 V -1 03/24/25, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76140

  15. Benjamin Franzke uploaded patch set 12 CR +1 V +1 03/24/25, 12:01

  16. core-ci voted on patch set 12 V +1 03/24/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76146

  17. Benjamin Kott uploaded patch set 13 CR +1 V +1 03/25/25, 09:47

  18. core-ci voted on patch set 13 V +1 03/25/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76227

  19. Benjamin Kott rebased onto patch set 14 V +1 03/25/25, 10:02

  20. core-ci voted on patch set 14 V +1 03/25/25, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76229

  21. Benjamin Kott uploaded patch set 15 V +1 03/25/25, 10:31

  22. core-ci voted on patch set 15 V +1 03/25/25, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76234

  23. Andreas Kienast voted on patch set 15 CR +1 V +1 03/25/25, 12:29

  24. Benjamin Franzke voted on patch set 15 CR +2 V +2 03/25/25, 15:52

  25. Benjamin Franzke merged patch set 16 03/25/25, 16:03