88596[TASK] Upgrade to `doctrine/dbal:~4.3.3`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+12 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.php3deleted+0 −122
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/MySQLSchemaManager.php+75 −55
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/PostgreSQLSchemaManager.php+75 −122
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/SQLiteSchemaManager.php+1 −6
- typo3/sysext/core/Classes/Database/ConnectionPool.php+4 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+103 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureMySQLSchemaManager.phpdeleted+0 −48
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixturePostgreSQLSchemaManager.phpdeleted+0 −48
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureSQLiteSchemaManager.phpdeleted+0 −48
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/MySQLSchemaManagerTest.phpdeleted+0 −123
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/PostgreSQLSchemaManagerTest.phpdeleted+0 −112
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/SQLiteSchemaManagerTest.phpdeleted+0 −101
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/install/composer.json+1 −1
- typo3/sysext/redirects/composer.json+1 −1
- composer.json+1 −1
- composer.lock+15 −15
Review log 4173
Show 2448 earlier messages
-
Stefan Bürk uploaded patch set 1 03/15/25, 14:08
-
core-ci voted on patch set 1 V -1 03/15/25, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75641
-
Stefan Bürk marked it work in progress 03/15/25, 17:57
-
Stefan Bürk uploaded patch set 2
V -103/30/25, 14:16 -
core-ci voted on patch set 2 V -1 03/30/25, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76669
-
Stefan Bürk uploaded patch set 3
V -103/30/25, 15:41 -
core-ci voted on patch set 3 V -1 03/30/25, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76670
-
Stefan Bürk uploaded patch set 4
V -103/30/25, 16:15 -
core-ci voted on patch set 4 V -1 03/30/25, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76671
-
Stefan Bürk uploaded patch set 5
V -103/30/25, 16:31 -
core-ci voted on patch set 5 V -1 03/30/25, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76672
-
Stefan Bürk uploaded patch set 6
V -103/30/25, 16:40 -
core-ci voted on patch set 6 V +1 03/30/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76673
-
core-ci voted on patch set 6 V -1 03/30/25, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76674
-
Stefan Bürk uploaded patch set 7
V -106/04/25, 14:26 -
core-ci voted on patch set 7 V -1 06/04/25, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79868
-
Stefan Bürk uploaded patch set 8
V -106/04/25, 17:21 -
core-ci voted on patch set 8 V -1 06/04/25, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79884
-
Stefan Bürk uploaded patch set 9
V -106/04/25, 21:25 -
core-ci voted on patch set 9 V -1 06/04/25, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79891
-
Stefan Bürk uploaded patch set 10
V -106/04/25, 21:36 -
core-ci voted on patch set 10 V -1 06/04/25, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79892
-
Stefan Bürk rebased onto patch set 11
V -106/05/25, 14:34 -
core-ci voted on patch set 11 V -1 06/05/25, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79934
-
Stefan Bürk rebased onto patch set 12
V -106/05/25, 15:07 -
core-ci voted on patch set 12 V -1 06/05/25, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79937
-
Stefan Bürk uploaded patch set 13
V -106/05/25, 15:30 -
core-ci voted on patch set 13 V -1 06/05/25, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79940
-
Stefan Bürk rebased onto patch set 14
V -106/05/25, 16:49 -
core-ci voted on patch set 14 V +1 06/05/25, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79944
-
core-ci commented on patch set 14 06/05/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79946
-
Stefan Bürk uploaded patch set 15 06/05/25, 17:58
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 15 V +1 06/05/25, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79948
-
Stefan Bürk uploaded patch set 16
V +106/05/25, 19:40 -
core-ci voted on patch set 16 V +1 06/05/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79951
-
Stefan Bürk uploaded patch set 17
V +106/10/25, 04:36 -
core-ci voted on patch set 17 V +1 06/10/25, 04:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80095
-
Stefan Bürk uploaded patch set 18
V +108/01/25, 09:42 -
core-ci voted on patch set 18 V +1 08/01/25, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82622
-
core-ci commented on patch set 18 08/01/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82624
-
Stefan Bürk updated the commit message in patch set 19
V +108/01/25, 10:22 -
Stefan Bürk marked it ready for review 08/01/25, 10:22
-
core-ci voted on patch set 19 V +1 08/01/25, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82626
-
Benni Mack updated the commit message in patch set 20
V +108/01/25, 10:51 -
core-ci voted on patch set 20 V +1 08/01/25, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82627
-
Oliver Klee updated the commit message in patch set 21
V +108/01/25, 11:01 -
core-ci voted on patch set 21 V +1 08/01/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82628
-
Benjamin Franzke commented on patch set 21 08/01/25, 12:27
CustomDoctrineTypesColumnDefinitionTrait.php:87The method `processCustomDoctrineTypesColumnDefinition` is used for all platforms (mariadb, postgres and sqlite), but `column_type` refers to the mariadb specific `COLUMN_TYPE` extension [1], right? How is it ensured that this code works for postgres and sqlite? I ask because I'm dump and do not understand this. I see that test cases are adapted with the expection that postgres and sqlite deliver this value, but I don't see where the platforms, doctrine or our codebase would set this value. Maybe you can shed some light on that? [1] https://mariadb.com/docs/server/reference/system-tables/information-schema/information-schema-tables/information-schema-columns-table#:~:text=%2C%20otherwise%20NULL.-,COLUMN_TYPE,-Column%20definition%2C%20a
-
Stefan Bürk marked it work in progress 08/01/25, 13:55
-
Stefan Bürk uploaded patch set 22
V +109/25/25, 11:00 -
core-ci voted on patch set 22 V -1 09/25/25, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85502
-
Stefan Bürk uploaded patch set 23
V -109/25/25, 11:21 -
core-ci voted on patch set 23 V +1 09/25/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85504
-
core-ci voted on patch set 23 V -1 09/25/25, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85505
-
core-ci voted on patch set 23 V +1 09/25/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85505
-
Stefan Bürk commented on patch set 23 09/25/25, 13:25
CustomDoctrineTypesColumnDefinitionTrait.php:87ReplySorry for the late answer. > I ask because I'm dump and do not understand this You are not dump and even the experienced and best people may need someone to shed some light onto the way to avoid getting lost from time to time, so I will try that now and answer your question while also explaining the changes made during investigating the change again based on your more than valid question and remark! Originally, doctrine/dbal used a normalized look onto things and splitted them up into vendor specific things, as you already mention `COLUMN_TYPE` for MySQL/MariaDB and you are right, that for "PostgreSQL/SQLite" that should be something else. The trait had a conditional check for the dbType (enum|set) in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596/21/typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.php#57 and as only MySQL/MariaDB supported that type (from the TYPO3 supported databases) the code matched MariaDB/MySQL and was safe. I added the trait back then to all SchemaManagers in case there would be other generic/dedicated custom changes required, not making the "condition" clear enough. Instead of "creating" that now dedicated for each of them, and due to the fact that doctrine/dbal already does a lot of that already directly (which we have cloned) I decided to remove the trait now completly, removing the custom/fallback to doctrine original (cloned) from the extended SchemaManager. The required adoptions for the TYPO3 custom `SET` type handling has been added to `MySQLSchemaManager` (documented with code comments). With that I finally dropped the unit tests, which were nasty, did the wrong thing for PostgresSQL/SQLite not supporting it anyway hidden by mocked method returns not reflecting the reality. For MySQL/MariaDB I added the "value" parsing verification to the functional `SchemaManagerTests` literally testing the same. I also added addtional stuff testing the "support" of the custom types, which revealed that the TYPO3 SetType is not only registered but also mapped to all connections even for connection platforms not supporting `SET`. That should be streamlined to make that also correct and I added comment in the connection pool now. Regarding "custom" doctrine type handling there are also request pending to make that kind of configurable/extendable, so I postponed that "streamlining" as part of looking into that "feature" and documented in the test for the SET time the "incorrect" expected platforms. Hope that is okay for everyone. -
Stefan Bürk uploaded patch set 24
V +109/25/25, 13:28 -
core-ci voted on patch set 24 V +1 09/25/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85521
-
Stefan Bürk marked it ready for review 09/26/25, 14:55
-
Oliver Klee voted on patch set 24 V +1 09/26/25, 19:02
-
Simon Schaufelberger uploaded patch set 25
V +110/01/25, 19:37 -
core-ci voted on patch set 25 V +1 10/01/25, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85835
-
Oliver Klee voted on patch set 25 V +1 10/01/25, 20:02
-
Stefan Bürk uploaded patch set 26
V +110/02/25, 21:52 -
Stefan Bürk commented on patch set 26 10/02/25, 21:52
CustomDoctrineTypesColumnDefinitionTrait.php:87ReplyDone -
Oliver Klee voted on patch set 26 V +1 10/02/25, 21:58
-
core-ci voted on patch set 26 V +1 10/02/25, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85945
-
Benjamin Franzke uploaded patch set 27
V +110/06/25, 08:54 -
core-ci voted on patch set 27 V +1 10/06/25, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86064
-
Oliver Klee voted on patch set 27 V +1 10/06/25, 09:22
-
Christian Kuhn voted on patch set 27 CR +1 V +1 10/06/25, 11:47
-
Stefan Bürk voted on patch set 27 CR +2 V +2 10/06/25, 12:02
-
Stefan Bürk merged patch set 28 10/06/25, 12:54