88597[TASK] Improve PAGEVIEW error message for missing template files
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php5+20 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php+16 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/TypoScript/invalidPath.typoscriptnew+3 −0
Review log 1318
-
Lina Wolf uploaded patch set 1 03/15/25, 17:59
-
core-ci voted on patch set 1 V -1 03/15/25, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75642
-
Garvin Hicking updated the commit message in patch set 2
V -103/15/25, 20:37 -
Garvin Hicking commented on patch set 2 03/15/25, 20:39
-
core-ci voted on patch set 2 V -1 03/15/25, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75644
-
Lina Wolf uploaded patch set 3
V -103/16/25, 09:31 -
Lina Wolf commented on patch set 2 03/16/25, 09:32
PageViewContentObject.php:123ReplyI think usages like this one are easy to find and fix once your established a better solution. Calling a viewhelper to create a link in an exceptions seems not very elegant to me? That is not what viewhelpers are for? -
core-ci voted on patch set 3 V +1 03/16/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75659
-
Garvin Hicking commented on patch set 3 03/17/25, 08:46
PageViewContentObject.php:123ReplyI would like it like this: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88611 [TASK] Use abstract docs.typo3.org linking service method ``` throw new InvalidTemplateResourceException( sprintf( 'PAGEVIEW TypoScript object: Failed to resolve the expected template file "%s" for layout "%s". See also: %s. The following paths were checked: %s', $templateFileName, $pageLayoutName, (new Typo3Information())->getDocsLink('t3tsref:cobj-pageview'), $checkedPaths, ), 1742058289, $e ); ``` What do you think? -
Lina Wolf commented on patch set 3 03/17/25, 08:50
PageViewContentObject.php:123ReplyLooks good -
Garvin Hicking uploaded patch set 4
V +103/18/25, 08:03Adjust to new getDocsLink API -
Garvin Hicking uploaded patch set 5 03/18/25, 08:04
Address CGL -
Garvin Hicking commented on patch set 5 CR +1 03/18/25, 08:04
PageViewContentObject.php:123ReplyDone -
core-ci voted on patch set 4 V -1 03/18/25, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75762
-
core-ci voted on patch set 5 V +1 03/18/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75763
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 03/18/25, 08:52
-
Benni Mack voted on patch set 5 CR +2 V +2 03/24/25, 20:04
-
Benni Mack merged patch set 6 03/24/25, 20:04
PageViewContentObject.php:123