88598[BUGFIX] Handle relative links with / as internal links
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Georg Ringer uploaded patch set 1 03/16/25, 08:04
-
Georg Ringer commented on patch set 1 03/16/25, 08:04
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/16/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75655
-
Benni Mack uploaded patch set 2
V +103/16/25, 16:22 -
core-ci voted on patch set 2 V -1 03/16/25, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75665
-
Chris Müller commented on patch set 2 03/16/25, 18:05
ExternalUrlLinkBuilder.php:34What about links starting with "//", like "//typo3.org/" which is a totally valid external link (relative to the protocol). -
Benni Mack commented on patch set 2 03/16/25, 21:43
ExternalUrlLinkBuilder.php:34Replythat's why i added tests... -
Benni Mack commented on patch set 3
V -103/16/25, 21:43Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 03/16/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75669
-
Benni Mack commented on patch set 3 CR +1 V +1 03/16/25, 21:55
ExternalUrlLinkBuilder.php:34Replyfixed. -
Garvin Hicking updated the commit message in patch set 4
CR +1V +103/17/25, 06:45 -
Garvin Hicking voted on patch set 4 CR +1 V +1 03/17/25, 06:45
-
core-ci voted on patch set 4 V +1 03/17/25, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75688
-
Benni Mack voted on patch set 4 CR +2 V +2 03/17/25, 08:38
-
Benni Mack merged patch set 5 03/17/25, 08:38