Review main Merged

88598[BUGFIX] Handle relative links with / as internal links

Georg Ringer CR +2 V +2 Normal +103 −1 updated 03/17/25, 08:38

Commit message

If a link is created not using the link API but using an external URL
starting with "/", it should still use the internal target and not
the default "_blank" value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Georg Ringer uploaded patch set 1 03/16/25, 08:04

  2. Georg Ringer commented on patch set 1 03/16/25, 08:04

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/16/25, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75655

  4. Benni Mack uploaded patch set 2 V +1 03/16/25, 16:22

  5. core-ci voted on patch set 2 V -1 03/16/25, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75665

  6. Chris Müller commented on patch set 2 03/16/25, 18:05

    ExternalUrlLinkBuilder.php:34

    What about links starting with "//", like "//typo3.org/" which is a totally valid external link (relative to the protocol).
  7. Benni Mack commented on patch set 2 03/16/25, 21:43

    ExternalUrlLinkBuilder.php:34 Reply

    that's why i added tests...
  8. Benni Mack commented on patch set 3 V -1 03/16/25, 21:43

    Published edit on patch set 2.
  9. core-ci voted on patch set 3 V +1 03/16/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75669

  10. Benni Mack commented on patch set 3 CR +1 V +1 03/16/25, 21:55

    ExternalUrlLinkBuilder.php:34 Reply

    fixed.
  11. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 03/17/25, 06:45

  12. Garvin Hicking voted on patch set 4 CR +1 V +1 03/17/25, 06:45

  13. core-ci voted on patch set 4 V +1 03/17/25, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75688

  14. Benni Mack voted on patch set 4 CR +2 V +2 03/17/25, 08:38

  15. Benni Mack merged patch set 5 03/17/25, 08:38