Review main Abandoned

88599[TASK] Show useful methods using the debugger

Georg Ringer CR 0 V -1 Easy +26 −1 updated 09/10/26, 11:40

Commit message

Don't just show properties but also public properties. Currently limited
to public methods which can be used in e.g. fluid, so no arguments
required.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 2

Review log 1015

  1. Georg Ringer uploaded patch set 1 03/16/25, 08:30

  2. core-ci voted on patch set 1 V -1 03/16/25, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75656

  3. Jigal van Hemert commented on patch set 1 03/21/25, 12:07

    Thanks! This is really useful when working with Fluid templates.

    DebuggerUtility.php:434 Unresolved

    Fluid also checks methods starting with 'has' (see https://github.com/TYPO3/Fluid/blob/main/src/Core/Variables/StandardVariableProvider.php#L110 ) Shouldn't we also check that there isn't a public property with the method name (without has/is/get)? If someone adds a getter for a public property it shows up twice.

    DebuggerUtility.php:438

    I'm not sure if the method name with or without the has/get/is prefix should be shown. Quite a few people who create Fluid template are unaware of the possibility to use the name of a get/has/is method as accessor. Or should there be a label about the use of a Fluid accessor without the prefix?
  4. Georg Ringer uploaded patch set 2 V -1 09/08/25, 06:03

  5. core-ci voted on patch set 2 V -1 09/08/25, 06:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84598

  6. Georg Ringer uploaded patch set 3 V -1 09/09/25, 13:15

  7. core-ci voted on patch set 3 V -1 09/09/25, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84706

  8. Georg Ringer commented on patch set 4 V -1 09/10/25, 14:16

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 09/10/25, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84784

  10. Georg Ringer commented on patch set 4 09/12/25, 09:08

    This change is ready for review.
  11. Garvin Hicking commented on patch set 4 09/12/25, 11:02

    DebuggerUtility.php:438 Reply Unresolved

    Please also see ext:includekrexx and https://review.typo3.org/c/Packages/TYPO3.CMS/+/84443 - I once went into a similar rabbit hole and found the extension much more beneficial than hacking away here and reaching 5% of the extension's functionality.
  12. Georg Ringer commented on patch set 4 09/15/25, 06:45

    @garvin@hick.ing thanks, yeah I don't try to fix everything, however having those methods would help integrators a lot
  13. Benni Mack updated the commit message in patch set 5 V +1 04/22/26, 06:32

  14. core-ci voted on patch set 5 V -1 04/22/26, 07:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100723

  15. Georg Ringer abandoned the change 09/10/26, 11:40