Review main Merged

88600[BUGFIX] Use correct error message in DateRangeValidator

Georg Ringer CR +2 V +2 Easy +12 −6 updated 03/27/25, 19:29

Commit message

Switch the error messages of DateRangeValidator.
If the minimum date is not reached, the given date must be greater, if
the maximum date is reached, the given date must be lower.

Also improve the tests which just checked if any error happened and not
which one.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Georg Ringer uploaded patch set 1 03/16/25, 08:57

  2. Georg Ringer commented on patch set 1 03/16/25, 08:57

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/16/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75657

  4. Torben Hansen commented on patch set 1 03/16/25, 10:43

    reached
    Just curious: Is this new to TYPO3 commit messages?
  5. Garvin Hicking updated the commit message in patch set 2 V +1 03/16/25, 10:44

  6. Garvin Hicking commented on patch set 2 03/16/25, 10:44

    Reply

    Done

    Reply

    Done
  7. Garvin Hicking commented on patch set 2 03/16/25, 10:46

    DateRangeValidator.php:66

    should this be 687?
  8. core-ci voted on patch set 2 V +1 03/16/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75660

  9. Georg Ringer commented on patch set 3 V +1 03/17/25, 08:04

    Published edit on patch set 2.
  10. core-ci voted on patch set 3 V +1 03/17/25, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75695

  11. Simon Schaufelberger commented on patch set 3 CR +1 V +1 03/18/25, 08:55

    DateRangeValidator.php:66 Reply

    Done
  12. Torben Hansen voted on patch set 3 CR +1 V +1 03/18/25, 17:27

  13. Benni Mack voted on patch set 3 CR +1 V +1 03/27/25, 16:25

  14. Georg Ringer voted on patch set 3 CR +2 V +2 03/27/25, 19:29

  15. Georg Ringer merged patch set 4 03/27/25, 19:29