Review main Merged

88604[FEATURE] PSR-14 event to modify URLs for integrity check

Philipp Kitzberger CR +2 V +2 Hard +256 −62 updated 03/29/25, 08:12

Commit message

A new PSR-14 event
AfterPageUrlsForSiteForRedirectIntegrityHaveBeenCollectedEvent is added
which allows TYPO3 Extensions to register event listeners to modify
the list of URLs that are being processed by the CLI command :ref:.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1521

  1. Philipp Kitzberger uploaded patch set 1 03/16/25, 15:02

  2. core-ci voted on patch set 1 V -1 03/16/25, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75663

  3. Philipp Kitzberger uploaded patch set 2 V -1 03/16/25, 15:22

  4. core-ci voted on patch set 2 V -1 03/16/25, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75664

  5. Andreas Kienast commented on patch set 2 CR -1 03/16/25, 15:30

    You've edited an existing ReST file instead of uploading a new one.
  6. Philipp Kitzberger uploaded patch set 3 CR -1 V -1 03/16/25, 20:41

  7. Philipp Kitzberger commented on patch set 3 03/16/25, 20:44

    Reply

    Argl! Fine, you got me ;-)
  8. core-ci voted on patch set 3 V -1 03/16/25, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75667

  9. Philipp Kitzberger uploaded patch set 4 V -1 03/16/25, 21:23

  10. core-ci voted on patch set 4 V +1 03/16/25, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75668

  11. Jörg Bösche voted on patch set 4 CR +1 03/24/25, 09:02

  12. Benni Mack uploaded patch set 5 CR +1 V +1 03/24/25, 11:02

  13. Benni Mack uploaded patch set 6 03/24/25, 11:04

  14. Benni Mack voted on patch set 6 CR +1 V +1 03/24/25, 11:05

  15. Benni Mack commented on patch set 6 03/24/25, 11:05

    side-note: The whole code is ugly when generating URLs, and needs to be re-built, but not for today, I'd say.
  16. core-ci voted on patch set 5 V +1 03/24/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76139

  17. core-ci voted on patch set 6 V +1 03/24/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76142

  18. Georg Ringer voted on patch set 6 CR +2 V +2 03/24/25, 20:40

  19. Georg Ringer merged patch set 7 03/24/25, 20:40

  20. Lina Wolf commented on patch set 7 03/29/25, 08:07

  21. Lina Wolf commented on patch set 7 03/29/25, 08:12