Review main Merged

88614[BUGFIX] Ensure internal fields can be used in label_alt

Benni Mack CR +2 V +2 Easy +47 −2 updated 03/17/25, 14:24

Commit message

Due to usage of the Schema API in EditDocumentController,
a side-effect while using
$GLOBALS[TCA][$table][ctrl][label_alt] = 'uid';
was exposed where Schema API needs some minor
adjustments by mapping a new SystemInternalFieldType
(without any type, and - by default - NOT inside
the FieldTypeFactory) is added, which is used
in the LabelCapability.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 03/17/25, 13:16

  2. core-ci voted on patch set 1 V -1 03/17/25, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75715

  3. Georg Ringer commented on patch set 2 V -1 03/17/25, 14:07

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 03/17/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75719

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 03/17/25, 14:16

  6. Georg Ringer voted on patch set 2 CR +2 V +2 03/17/25, 14:24

  7. Georg Ringer merged patch set 3 03/17/25, 14:24