Review main Merged

88617[TASK] Remove ignore validation from Indexed search controller

Lina Wolf CR +2 V +2 Easy +11 −11 updated 03/23/25, 22:18

Commit message

There has never been a validator for an
array in the Core.

The annotation has been there since many
versions while it does nothing.

As a drive-by improve the comments.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1

Issues 1

Files 1

Review log 911

  1. Lina Wolf uploaded patch set 1 03/17/25, 14:51

  2. core-ci voted on patch set 1 V +1 03/17/25, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75727

  3. Stefan Froemken commented on patch set 1 CR +1 V +1 03/17/25, 15:08

    Search is still working without the ignorevalidation annotation. Thank you.
  4. Simon Schaufelberger commented on patch set 1 CR +1 V +1 03/17/25, 15:10

    I would also backport this into v13
  5. Lina Wolf commented on patch set 1 03/17/25, 15:16

    Reply

    As it doesnt really cause any bug why backport it?
  6. Simon Schaufelberger commented on patch set 1 03/17/25, 16:01

    Reply

    tiny speed improvement as the annotation doesn't need to be parsed and the class is internal anyway. and not to forget: code cleanup ;)
  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 03/23/25, 22:08

  8. Benni Mack commented on patch set 2 CR +1 V +1 03/23/25, 22:09

    Reply

    Done
    Thank you, Lina, for this one!
  9. Georg Ringer voted on patch set 2 CR +2 V +2 03/23/25, 22:10

  10. Georg Ringer merged patch set 3 03/23/25, 22:10

  11. core-ci voted on patch set 2 V +1 03/23/25, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76097