Review 12.4 Merged

88635[BUGFIX] Dispatch `multiRecordSelection:checkbox:state:changed` once

Andreas Kienast CR +2 V +2 Easy +2 −7 updated 03/18/25, 08:01

Commit message

The module `@typo3/backend/multi-record-selection` uses multiple events
to notify about state changes. Unfortunately, it happened that the event
`multiRecordSelection:checkbox:state:changed` was dispatched twice when
the checkboxes are toggled via the action dropdown:

* explicitly in `changeCheckboxState()`
* by the `change` event listener registered in
  `registerDispatchCheckboxStateChangedEvent()`

The explicit call in `changeCheckboxState()` is removed, as the `change`
event is triggered anyway and it's event handler is also called when
single rows get (un)checked.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 03/18/25, 07:42

  2. core-ci voted on patch set 1 V +1 03/18/25, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75759

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 03/18/25, 08:00

  4. Andreas Kienast merged patch set 2 03/18/25, 08:01