88636[TASK] Remove deprecated call to `xml_set_object()`, add tests
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/extensionmanager/Classes/Parser/ExtensionXmlParser.php+1 −2
- typo3/sysext/extensionmanager/Tests/Unit/Fixtures/ExtensionXmlParserObserverFixture.phpnew+63 −0
- typo3/sysext/extensionmanager/Tests/Unit/Fixtures/invalid-extensions.xmlnew+5 −0
- typo3/sysext/extensionmanager/Tests/Unit/Fixtures/valid-extensions.xmlnew+69 −0
- typo3/sysext/extensionmanager/Tests/Unit/Parser/ExtensionXmlParserTest.php+106 −0
Review log 2124
-
Garvin Hicking uploaded patch set 1 03/18/25, 07:56
-
core-ci voted on patch set 1 V +1 03/18/25, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75761
-
Andreas Kienast commented on patch set 1 03/18/25, 08:27
12.4 is declared to be compatible with PHP 8.4 as well -
Garvin Hicking commented on patch set 1 03/18/25, 08:31
Reply
I didn't figure this kind of cleanup to be applicable to the "priority mode" of 12.4, but I'm fine with any range. -
Andreas Kienast commented on patch set 1 03/18/25, 08:54
Reply
Removing deprecated code that may lead to unnecessary bloat in log files is a fine reason for me to backport this in priority branches as well. :) -
Garvin Hicking updated the commit message in patch set 2
V +103/18/25, 10:04 -
Garvin Hicking commented on patch set 2 03/18/25, 10:04
Reply
Acknowledged -
Markus Klein voted on patch set 2 CR +1 V +1 03/18/25, 10:05
-
core-ci voted on patch set 2 V +1 03/18/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75767
-
Andreas Kienast voted on patch set 2 CR +1 03/18/25, 11:13
-
Markus Klein commented on patch set 2 03/18/25, 13:17
Reply
> ... may lead to unnecessary bloat in log files ... we are not talking log files here, we are talking dysfunctional extension manager! (in dev mode, due to error reporting) -
Georg Ringer voted on patch set 2 CR +1 V +1 03/18/25, 15:15
-
Stefan Bürk commented on patch set 2 03/18/25, 18:58
That this was not covered by the pipeline means that this part of the code is not tested at all, neither direct nor indirect. -
Markus Klein commented on patch set 2 03/19/25, 08:25
Reply
Yep! And that nobody uses PHP 8.4 with classic installation to test extensions, obviously. ;-) -
Christian Kuhn voted on patch set 2 CR +1 V +1 03/19/25, 08:32
-
Garvin Hicking uploaded patch set 3
CR +1V +103/19/25, 09:03 -
Garvin Hicking commented on patch set 3 03/19/25, 09:04
Reply
Thank you Stefan, this was helpful for me. I've added tests and learnt a bit about the XML parser (and that it's f'in hard to get a dummy extensions.xml.gz because the server blocks normal WGET requests...) Please see if those are helpful. -
core-ci voted on patch set 3 V +1 03/19/25, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75811
-
Markus Klein voted on patch set 3 CR +1 V +1 03/19/25, 12:01
-
Benni Mack voted on patch set 3 CR +1 03/20/25, 10:56
-
Oliver Klee voted on patch set 3 V +1 03/20/25, 12:37
-
Benni Mack voted on patch set 3 V +1 03/24/25, 20:03
-
Georg Ringer voted on patch set 3 CR +2 V +2 03/24/25, 20:05
-
Georg Ringer merged patch set 4 03/24/25, 20:05