Review main Merged

88644[FEATURE] Associative array keys for TCA valuePicker items

Georg Ringer CR +2 V +2 Normal +190 −54 updated 03/29/25, 07:28

Commit message

The valuePicker configuration follows the syntax change used by the TCA
items and uses array keys `label` and `value`, added with #99739.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 1420

  1. Georg Ringer uploaded patch set 1 03/18/25, 16:37

  2. core-ci voted on patch set 1 V -1 03/18/25, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75785

  3. Georg Ringer uploaded patch set 2 V -1 03/18/25, 17:54

  4. core-ci voted on patch set 2 V -1 03/18/25, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75786

  5. Georg Ringer uploaded patch set 3 V -1 03/18/25, 18:21

  6. core-ci voted on patch set 3 V -1 03/18/25, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75788

  7. Georg Ringer uploaded patch set 4 V -1 03/18/25, 21:49

  8. core-ci voted on patch set 4 V +1 03/18/25, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75792

  9. Georg Ringer uploaded patch set 5 V +1 03/19/25, 06:51

  10. core-ci voted on patch set 5 V +1 03/19/25, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75808

  11. Georg Ringer commented on patch set 5 03/19/25, 08:03

    This change is ready for review.
  12. Georg Ringer rebased onto patch set 6 V +1 03/24/25, 21:39

  13. core-ci voted on patch set 6 V +1 03/24/25, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76186

  14. Benni Mack voted on patch set 6 CR +1 V +1 03/25/25, 20:27

  15. Stefan Bürk commented on patch set 6 03/25/25, 21:42

    Question 1: Are valuePicker also possible in flexform ? Question 2: If answer to 1 is yes, does the TCA migration (deprecation) also works when used in flexform ?
  16. Stefan Bürk commented on patch set 6 CR +1 V +1 03/26/25, 12:22

    Reply

    Tested and verified. FlexForm is also migrated and deprecation log written.
  17. Benni Mack voted on patch set 6 CR +2 V +2 03/26/25, 12:59

  18. Benni Mack merged patch set 7 03/26/25, 12:59

  19. Lina Wolf commented on patch set 7 03/29/25, 07:28