Review main Merged

88648[BUGFIX] Move flex form inline children along with its parent

Christian Kuhn CR +2 V +2 Nightmare +3684 −104 updated 03/22/25, 08:03

Commit message

When a record is moved to a different page, flex form inline
children have to be moved to that pid as well, just like "casual"
inline children. Current DataHandler does not do this. This can
lead to falsely deleted records if an old source page is later
deleted by an editor.

The patch establishes fixes and test scenarios for flexform inline
to see if children are properly moved when a parent is moved. The
change goes along with an additional refactoring within moveRecord(),
aiming to make everything more obvious and less convoluted. The test
.csv files have some `@todo` comments that outline fishy sorting and
workspace related details. Those should be elaborated on with
upcoming changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 31

Show 11 more files

Review log 3769

Show 2344 earlier messages
  1. Christian Kuhn uploaded patch set 1 03/19/25, 09:39

  2. core-ci voted on patch set 1 V -1 03/19/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75813

  3. Christian Kuhn uploaded patch set 2 V -1 03/19/25, 09:57

  4. Christian Kuhn uploaded patch set 3 03/19/25, 10:00

  5. core-ci voted on patch set 2 V +1 03/19/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75814

  6. core-ci voted on patch set 3 V +1 03/19/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75815

  7. Christian Kuhn uploaded patch set 4 V +1 03/19/25, 10:26

  8. core-ci voted on patch set 4 V +1 03/19/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75817

  9. Christian Kuhn uploaded patch set 5 V +1 03/19/25, 10:51

  10. Christian Kuhn uploaded patch set 6 03/19/25, 10:57

  11. core-ci voted on patch set 5 V +1 03/19/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75819

  12. core-ci voted on patch set 6 V +1 03/19/25, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75820

  13. Christian Kuhn uploaded patch set 7 V +1 03/19/25, 11:28

  14. core-ci voted on patch set 7 V -1 03/19/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75823

  15. Christian Kuhn uploaded patch set 8 V -1 03/19/25, 11:54

  16. core-ci voted on patch set 8 V +1 03/19/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75825

  17. Christian Kuhn uploaded patch set 9 V +1 03/19/25, 12:08

  18. core-ci voted on patch set 9 V +1 03/19/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75826

  19. Christian Kuhn uploaded patch set 10 V +1 03/19/25, 12:18

  20. core-ci voted on patch set 10 V -1 03/19/25, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75830

  21. Christian Kuhn uploaded patch set 11 V -1 03/19/25, 12:29

  22. Christian Kuhn uploaded patch set 12 03/19/25, 12:37

  23. core-ci voted on patch set 11 V +1 03/19/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75832

  24. core-ci voted on patch set 12 V +1 03/19/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75834

  25. Christian Kuhn uploaded patch set 13 V +1 03/19/25, 12:49

  26. Christian Kuhn uploaded patch set 14 03/19/25, 12:53

  27. Christian Kuhn uploaded patch set 15 03/19/25, 12:55

  28. core-ci voted on patch set 13 V -1 03/19/25, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75835

  29. Christian Kuhn uploaded patch set 16 03/19/25, 13:04

  30. core-ci voted on patch set 15 V -1 03/19/25, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75837

  31. core-ci voted on patch set 14 V -1 03/19/25, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75836

  32. Justus Moroni wrote 03/19/25, 13:07

    Removed cc Justus Moroni.
  33. Christian Kuhn uploaded patch set 17 03/19/25, 13:08

  34. core-ci voted on patch set 16 V -1 03/19/25, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75838

  35. core-ci voted on patch set 17 V +1 03/19/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75839

  36. Christian Kuhn uploaded patch set 18 V +1 03/19/25, 13:35

  37. Christian Kuhn uploaded patch set 19 03/19/25, 13:42

  38. core-ci voted on patch set 18 V +1 03/19/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75840

  39. core-ci voted on patch set 19 V +1 03/19/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75842

  40. Christian Kuhn updated the commit message in patch set 20 V +1 03/19/25, 14:07

  41. core-ci voted on patch set 20 V +1 03/19/25, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75843

  42. Christian Kuhn uploaded patch set 21 V +1 03/19/25, 14:57

  43. core-ci voted on patch set 21 V +1 03/19/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75844

  44. Christian Kuhn uploaded patch set 22 V +1 03/19/25, 15:46

  1. core-ci voted on patch set 22 V +1 03/19/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75846

  2. Christian Kuhn uploaded patch set 23 V +1 03/19/25, 16:08

  3. core-ci voted on patch set 23 V +1 03/19/25, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75848

  4. Christian Kuhn uploaded patch set 24 V +1 03/19/25, 16:37

  5. core-ci voted on patch set 24 V +1 03/19/25, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75849

  6. Christian Kuhn uploaded patch set 25 V +1 03/20/25, 14:01

  7. core-ci voted on patch set 25 V +1 03/20/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75899

  8. Christian Kuhn uploaded patch set 26 V +1 03/21/25, 09:15

  9. core-ci voted on patch set 26 V +1 03/21/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75949

  10. Christian Kuhn uploaded patch set 27 V +1 03/21/25, 11:38

  11. core-ci voted on patch set 27 V +1 03/21/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75953

  12. Christian Kuhn uploaded patch set 28 V +1 03/21/25, 12:36

  13. core-ci voted on patch set 28 V +1 03/21/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75955

  14. Christian Kuhn uploaded patch set 29 V +1 03/21/25, 13:58

  15. core-ci voted on patch set 29 V +1 03/21/25, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75956

  16. Christian Kuhn updated the commit message in patch set 30 V +1 03/21/25, 14:32

  17. Christian Kuhn updated the commit message in patch set 31 03/21/25, 14:35

  18. core-ci voted on patch set 30 V +1 03/21/25, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75958

  19. core-ci voted on patch set 31 V +1 03/21/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75959

  20. Benni Mack updated the commit message in patch set 32 V +1 03/21/25, 15:40

  21. Benni Mack commented on patch set 32 CR +1 V +1 03/21/25, 15:41

    Thanks for providing tests for Flex!
  22. core-ci voted on patch set 32 V +1 03/21/25, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75962

  23. Stefan Bürk voted on patch set 32 CR +1 V +1 03/21/25, 20:00

  24. Christian Kuhn voted on patch set 32 CR +2 V +2 03/22/25, 08:03

  25. Christian Kuhn merged patch set 33 03/22/25, 08:03