Review main Merged

88650[BUGFIX] Use buttons for form-wizard-icon selector list

Benjamin Kott CR +2 V +2 Easy +22 −20 updated 03/25/25, 13:37

Commit message

Updated the core to exclusively render buttons for the icon selector
list, replacing anchor tags. To ensure backward compatibility, anchor
variants remain supported for users with custom nodes relying on this
feature.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Benjamin Kott uploaded patch set 1 03/19/25, 12:10

  2. Benjamin Kott uploaded patch set 2 03/19/25, 12:11

  3. Benjamin Kott updated the commit message in patch set 3 03/19/25, 12:12

  4. core-ci voted on patch set 1 V +1 03/19/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75827

  5. core-ci voted on patch set 2 V -1 03/19/25, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75828

  6. core-ci voted on patch set 3 V -1 03/19/25, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75829

  7. Benjamin Franzke uploaded patch set 4 V -1 03/21/25, 06:25

  8. Benjamin Franzke commented on patch set 4 03/21/25, 06:25

    I wonder how should an extension have rendered this manually? LIke completely overwritten via xclass? Do you have a concrete example at hand? Otherwise I'd be in favor of dropping the fallback code.
  9. Benjamin Franzke voted on patch set 4 V +1 03/21/25, 06:26

  10. core-ci voted on patch set 4 V +1 03/21/25, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75931

  11. Benjamin Franzke commented on patch set 4 CR +1 03/24/25, 08:22

    Reply

    Acknowledged
  12. Andreas Kienast commented on patch set 4 V -1 03/25/25, 12:24

    There is a suspicious border around the icons now, tested with backend layouts.
  13. Benjamin Kott uploaded patch set 5 CR +1 V +1 03/25/25, 12:26

  14. Benjamin Kott commented on patch set 5 03/25/25, 12:26

    Reply

    Done
  15. Andreas Kienast voted on patch set 5 CR +1 V +1 03/25/25, 12:27

  16. core-ci voted on patch set 5 V +1 03/25/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76244

  17. Benjamin Franzke voted on patch set 5 CR +2 V +2 03/25/25, 13:20

  18. Benjamin Franzke merged patch set 6 03/25/25, 13:37