88650[BUGFIX] Use buttons for form-wizard-icon selector list
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/forms/_form-wizard.scss+9 −7
- Build/Sources/TypeScript/backend/form-engine/element/select-single-element.ts+5 −5
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-single-element.js+1 −1
Review log 1419
-
Benjamin Kott uploaded patch set 1 03/19/25, 12:10
-
Benjamin Kott uploaded patch set 2 03/19/25, 12:11
-
Benjamin Kott updated the commit message in patch set 3 03/19/25, 12:12
-
core-ci voted on patch set 1 V +1 03/19/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75827
-
core-ci voted on patch set 2 V -1 03/19/25, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75828
-
core-ci voted on patch set 3 V -1 03/19/25, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75829
-
Benjamin Franzke uploaded patch set 4
V -103/21/25, 06:25 -
Benjamin Franzke commented on patch set 4 03/21/25, 06:25
I wonder how should an extension have rendered this manually? LIke completely overwritten via xclass? Do you have a concrete example at hand? Otherwise I'd be in favor of dropping the fallback code. -
Benjamin Franzke voted on patch set 4 V +1 03/21/25, 06:26
-
core-ci voted on patch set 4 V +1 03/21/25, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75931
-
Benjamin Kott commented on patch set 4 03/24/25, 06:13
-
Benjamin Franzke commented on patch set 4 CR +1 03/24/25, 08:22
Reply
Acknowledged -
Andreas Kienast commented on patch set 4 V -1 03/25/25, 12:24
There is a suspicious border around the icons now, tested with backend layouts. -
Benjamin Kott uploaded patch set 5
CR +1V +103/25/25, 12:26 -
Benjamin Kott commented on patch set 5 03/25/25, 12:26
Reply
Done -
Andreas Kienast voted on patch set 5 CR +1 V +1 03/25/25, 12:27
-
core-ci voted on patch set 5 V +1 03/25/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76244
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 03/25/25, 13:20
-
Benjamin Franzke merged patch set 6 03/25/25, 13:37