Review main Merged

88652[BUGFIX] Respect extendToSubpages in directory menus

Devid Messner CR +2 V +2 Normal +133 −0 updated 11/06/26, 22:12

Commit message

An HMENU with special = directory listed the subpages of a page the
visitor cannot access because of extendToSubpages, and requesting them
was denied afterwards. The menu now checks the rootline of its parent
page the same way the frontend does when a page is requested.

getMenu() stays, since going back to exec_getQuery() would undo the fix
for #96226 and lose showAccessRestrictedPages.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 914

  1. Devid Messner uploaded patch set 1 03/19/25, 17:08

  2. core-ci voted on patch set 1 V -1 03/19/25, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75850

  3. Devid Messner rebased onto patch set 2 V -1 04/02/25, 06:25

  4. core-ci voted on patch set 2 V -1 04/02/25, 06:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76841

  5. Benni Mack updated the commit message in patch set 3 V -1 04/22/26, 06:30

  6. core-ci voted on patch set 3 V -1 04/22/26, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100709

  7. Georg Ringer uploaded patch set 4 V -1 11/01/26, 17:47

  8. core-ci voted on patch set 4 V +1 11/01/26, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113033

  9. Georg Ringer uploaded patch set 5 V +1 11/06/26, 09:27

  10. core-ci voted on patch set 5 V +1 11/06/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113477

  11. Benni Mack voted on patch set 5 CR +1 V +1 11/06/26, 09:46

  12. Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/06/26, 15:16

  13. Garvin Hicking commented on patch set 5 CR +2 V +2 11/06/26, 20:46

    I've also benchmarked this, the impact was not relevant even with larger sample sizes. It does scale up a bit due if "special.value" has a lot of IDs.
  14. Garvin Hicking merged patch set 6 11/06/26, 22:12