Review main Merged

88653[BUGFIX] Add svg to RewriteRule for static files

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/22/25, 09:21

Commit message

Add missing extension `svg` to the RewriteRule in root htaccess file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Georg Ringer uploaded patch set 1 03/20/25, 05:53

  2. Georg Ringer commented on patch set 1 03/20/25, 05:53

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/20/25, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75871

  4. Garvin Hicking commented on patch set 1 03/20/25, 07:06

    what about webp, avif...? Which file types can get versioned filenames, do you know? Any that gets utilized in f:image or pagerenderer?
  5. Benni Mack commented on patch set 1 CR -1 03/20/25, 07:41

    In light of recent actions, I would prefer to triple-think about what is a "critical bugfix". - 12.4 is in critical bugfix mode - this change can be easily adapted by everybody by customizing their own htaccess - existing 12.4 installations will not be changed - new installations will get this flag. I truly hope that new installations in 2025 start with 13.4
  6. Georg Ringer updated the commit message in patch set 2 CR -1 V +1 03/20/25, 08:24

  7. core-ci voted on patch set 2 V +1 03/20/25, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75879

  8. Benni Mack voted on patch set 2 CR +1 V +1 03/21/25, 20:19

  9. Garvin Hicking commented on patch set 2 CR -1 03/21/25, 20:40

    what about avif, webp?
  10. Benni Mack commented on patch set 3 CR +1 V +1 03/21/25, 21:20

    Published edit on patch set 2.
  11. Benni Mack commented on patch set 3 CR +1 V +1 03/21/25, 21:20

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 03/21/25, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75990

  13. Christian Kuhn voted on patch set 3 CR +1 V +1 03/22/25, 07:39

  14. Benni Mack voted on patch set 3 CR +2 V +2 03/22/25, 09:21

  15. Benni Mack merged patch set 4 03/22/25, 09:21