Review main Merged

88656[TASK] Thin out PageTreeView and PagePositionMap classes

Benni Mack CR +2 V +2 Hard +92 −380 updated 03/22/25, 09:45

Commit message

Back in TYPO3 v7, we had 9 classes extending
AbstractTreeView, this change reduces the code
to just two classes:
* PageTreeView
* ExportPageTreeView

Most trees are rendered on the client side nowadays.

In addition, PagePositionMap, the paired class
of PageTreeView is cleaned up.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 68

  1. Benni Mack uploaded patch set 1 03/20/25, 09:21

  2. core-ci voted on patch set 1 V +1 03/20/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75881

  3. Benni Mack updated the commit message in patch set 2 V +1 03/21/25, 18:23

  4. core-ci voted on patch set 2 V +1 03/21/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75968

  5. Georg Ringer voted on patch set 2 CR +1 V +1 03/21/25, 19:45

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 03/22/25, 09:35

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/22/25, 09:45

  8. Benni Mack merged patch set 3 03/22/25, 09:45