Review main Merged

88659[TASK] Use Schema API in RelationHandler

Georg Ringer CR +2 V +2 Normal +74 −31 updated 03/21/25, 18:29

Commit message

Use the Schema API instead of direct TCA access in the
RelationHandler.

In addition, this change also fixes a small
bug in handling of
$schema->getCapability(TcaSchemaCapability::DefaultSorting)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1523

  1. Georg Ringer uploaded patch set 1 03/20/25, 12:45

  2. Georg Ringer commented on patch set 1 03/20/25, 12:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/20/25, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75889

  4. Georg Ringer uploaded patch set 2 V -1 03/20/25, 13:16

  5. core-ci voted on patch set 2 V -1 03/20/25, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75892

  6. Georg Ringer uploaded patch set 3 V -1 03/20/25, 13:36

  7. core-ci voted on patch set 3 V -1 03/20/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75896

  8. Benni Mack uploaded patch set 4 V -1 03/20/25, 16:10

  9. core-ci voted on patch set 4 V -1 03/20/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75903

  10. Benni Mack uploaded patch set 5 V -1 03/20/25, 20:24

  11. core-ci voted on patch set 5 V -1 03/20/25, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75909

  12. Benni Mack uploaded patch set 6 V -1 03/20/25, 21:25

  13. core-ci voted on patch set 6 V -1 03/20/25, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75912

  14. Benni Mack uploaded patch set 7 V -1 03/21/25, 08:04

  15. Benni Mack rebased onto patch set 8 03/21/25, 08:07

  16. core-ci voted on patch set 8 V +1 03/21/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75946

  17. core-ci voted on patch set 7 V -1 03/21/25, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75945

  18. Benni Mack voted on patch set 8 CR +1 V +1 03/21/25, 08:46

  19. Stefan Bürk commented on patch set 8 CR -1 03/21/25, 18:06

    Reviewing now ...
  20. Stefan Bürk voted on patch set 8 CR +1 V +1 03/21/25, 18:27

  21. Stefan Bürk commented on patch set 8 03/21/25, 18:27

    Reply

    Done
  22. Benni Mack voted on patch set 8 CR +2 V +2 03/21/25, 18:29

  23. Benni Mack merged patch set 9 03/21/25, 18:29