Review main Merged

88662[TASK] Migrate ElementInformationController to Schema API

Benni Mack CR +2 V +2 Normal +83 −62 updated 03/24/25, 19:17

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Benni Mack uploaded patch set 1 03/20/25, 21:06

  2. core-ci voted on patch set 1 V +1 03/20/25, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75911

  3. Benni Mack updated the commit message in patch set 2 V +1 03/21/25, 19:51

  4. core-ci voted on patch set 2 V +1 03/21/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75977

  5. Benni Mack commented on patch set 3 V +1 03/22/25, 09:23

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 03/22/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76010

  7. Stefan Bürk commented on patch set 3 03/24/25, 11:22

    ElementInformationController.php:322

    I'd suggest to use another variable name here, as it literally overrides that one retrieved in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88662/3/typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php#327 Currently not an issue, but considerable a potential issue in the future when code may be added later and using the wrong one - or expecting the main schema from above. What do you think ? ( `$schemaSysFileMetadata` )
  8. Benni Mack uploaded patch set 4 V +1 03/24/25, 18:19

  9. Stefan Bürk commented on patch set 4 03/24/25, 18:20

    ElementInformationController.php:322 Reply

    Done
  10. core-ci voted on patch set 4 V +1 03/24/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76164

  11. Stefan Bürk voted on patch set 4 CR +1 V +1 03/24/25, 18:31

  12. Georg Ringer voted on patch set 4 CR +2 V +2 03/24/25, 19:17

  13. Georg Ringer merged patch set 5 03/24/25, 19:17