88675[TASK] Migrate scheduler database to new storage format
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 33
- typo3/sysext/core/Documentation/Changelog/14.0/Important-106532-ChangedDatabaseStorageFormatForSchedulerTasks.rstnew+39 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+1 −7
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+10 −2
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+31 −17
- typo3/sysext/scheduler/Classes/Migration/SchedulerDatabaseStorageMigration.php2new+185 −0
- typo3/sysext/scheduler/Classes/Service/TaskService.php+5 −0
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php2+47 −5
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php+3 −1
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionTask.php+13 −0
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+9 −1
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php+26 −0
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+6 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+12 −0
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+3 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+13 −6
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+7 −3
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationTask.php+17 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+5 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableTask.php+12 −0
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+3 −1
Show 13 more files
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionTask.php+12 −0
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+7 −3
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionTask.php+16 −0
- typo3/sysext/scheduler/Classes/Task/TaskSerializer.php2+45 −16
- typo3/sysext/scheduler/Classes/Execution.php4+28 −0
- typo3/sysext/scheduler/Classes/Scheduler.php+17 −17
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageFailedMigrationApplied.csvnewbinary
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageFailedMigrationBase.csvnewbinary
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationApplied.csvnewbinary
- typo3/sysext/scheduler/Tests/Functional/Fixtures/DatabaseStorageMigrationBase.csvnewbinary
- typo3/sysext/scheduler/Tests/Functional/Migration/SchedulerDatabaseStorageMigrationTest.phpnew+57 −0
- typo3/sysext/scheduler/Tests/Unit/Task/TaskSerializerTest.php+51 −77
- typo3/sysext/scheduler/ext_tables.sql+3 −0
Review log 4768
Show 2843 earlier messages
-
Benni Mack uploaded patch set 1 03/21/25, 17:45
-
core-ci voted on patch set 1 V -1 03/21/25, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75965
-
Benni Mack uploaded patch set 2
V -103/21/25, 18:13 -
Benni Mack uploaded patch set 3 03/21/25, 18:19
-
core-ci voted on patch set 2 V -1 03/21/25, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75966
-
core-ci voted on patch set 3 V -1 03/21/25, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75967
-
Benni Mack uploaded patch set 4
V -103/21/25, 19:14 -
core-ci voted on patch set 4 V +1 03/21/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75972
-
Benni Mack marked it work in progress 03/22/25, 12:35
-
Benni Mack uploaded patch set 5
V +103/31/25, 15:59 -
Benni Mack uploaded patch set 6 03/31/25, 16:01
-
core-ci voted on patch set 5 V -1 03/31/25, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76726
-
core-ci voted on patch set 6 V -1 03/31/25, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76727
-
Benni Mack uploaded patch set 7
V -104/02/25, 06:20 -
core-ci voted on patch set 7 V -1 04/02/25, 06:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76840
-
Benni Mack uploaded patch set 8
V -104/03/25, 06:50 -
core-ci voted on patch set 8 V -1 04/03/25, 07:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76924
-
Benni Mack uploaded patch set 9
V -104/03/25, 10:25 -
core-ci voted on patch set 9 V -1 04/03/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76938
-
Benni Mack uploaded patch set 10
V -104/03/25, 10:38 -
core-ci voted on patch set 10 V +1 04/03/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76942
-
Christian Kuhn commented on patch set 10 04/08/25, 16:09
TaskSerializer.php:88do we really need the b/w layer in v14? couldn't we just say that running the upgrade wizard is mandatory in v14? we should expect people run the upgrade wizards when doing major upgrades. the task hydration is imho not API, so we should be able to do this in one go? -
Benni Mack uploaded patch set 11
V +104/08/25, 20:03 -
core-ci voted on patch set 11 V -1 04/08/25, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77238
-
Benni Mack uploaded patch set 12
V -104/09/25, 13:57 -
Benni Mack marked it ready for review 04/09/25, 13:57
-
core-ci voted on patch set 12 V -1 04/09/25, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77285
-
Benni Mack uploaded patch set 13
V -104/09/25, 14:03 -
Benni Mack commented on patch set 13 04/09/25, 14:04
SchedulerDatabaseStorageMigration.php:32ReplyDoneTaskSerializer.php:88ReplyDone -
core-ci voted on patch set 13 V +1 04/09/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77286
-
Christian Kuhn voted on patch set 13 CR +1 V +1 04/09/25, 17:19
-
Stefan Bürk voted on patch set 13 CR +1 V +1 04/09/25, 17:59
-
Garvin Hicking commented on patch set 13 04/09/25, 18:00
Execution.php:299```suggestion // The type cast is necessary as long as the migration (DB migration) exists, ```Execution.php:303Use a "todo" marker here?SchedulerDatabaseStorageMigration.php:46```suggestion return 'Each Scheduler Task was previously stored in a serialized object format in the database. This update wizard migrates records of this type to a JSON-formatted storage in the database.'; ``` -
Benni Mack commented on patch set 13 CR +2 V +2 04/09/25, 18:00
Thank you, that's an internal milestone! -
Benni Mack voted on patch set 13 V 0 CR -1 04/09/25, 18:01
-
Benni Mack uploaded patch set 14
CR +1V +104/09/25, 18:03 -
Stefan Bürk voted on patch set 14 CR +1 V +1 04/09/25, 18:07
-
Christian Kuhn voted on patch set 14 CR +1 V +1 04/09/25, 18:07
-
core-ci voted on patch set 14 V +1 04/09/25, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77306
-
Garvin Hicking commented on patch set 14 CR -1 04/09/25, 18:12
reviewingExecution.php:299ReplyDoneExecution.php:303ReplyDoneSchedulerDatabaseStorageMigration.php:46ReplyDone -
Garvin Hicking uploaded patch set 15
CR +1V +104/09/25, 19:39 -
core-ci voted on patch set 15 V +1 04/09/25, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77316
-
Benni Mack commented on patch set 15 CR -1 04/09/25, 19:49
needs more work
-
Benni Mack marked it work in progress 04/09/25, 19:49
-
Garvin Hicking commented on patch set 15 CR -1 04/09/25, 19:50
(Still on it) Missing a few non-EXT:scheduler tasks: typo3/sysext/extensionmanager/Classes/Task/UpdateExtensionListTask.php typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php typo3/sysext/recycler/Classes/Task/CleanerTask.php typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php For these the wizard upgrade doesn't populate 'parameters' properly and loses their state/content. -
Benni Mack uploaded patch set 16
CR -1V +104/09/25, 21:05 -
Benni Mack marked it ready for review 04/09/25, 21:05
-
Benni Mack commented on patch set 16 04/09/25, 21:09
Reply
they do not need to be upgraded. The issue as you mentioned is solved now -
core-ci voted on patch set 16 V +1 04/09/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77322
-
Benni Mack rebased onto patch set 17
V +104/09/25, 22:43 -
core-ci voted on patch set 17 V +1 04/09/25, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77367
-
Garvin Hicking uploaded patch set 18
V +104/10/25, 07:14 -
Garvin Hicking commented on patch set 18 CR +1 V +1 04/10/25, 07:16
Reply
I'm thinking it would be good to keep a few non-upgraded ones around for some time to catch issues better.Fixed one last detail that came up with testing (dynamic property assignment due to a serialized configuration of an old task). I really enjoy this change, thank you for pushing through. -
Garvin Hicking commented on patch set 18 04/10/25, 07:16
Reply
Done -
core-ci voted on patch set 18 V -1 04/10/25, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77390
-
core-ci commented on patch set 18 04/10/25, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77390
-
Garvin Hicking commented on patch set 19
CR +1V +104/10/25, 08:39Published edit on patch set 18. -
core-ci voted on patch set 19 V +1 04/10/25, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77412
-
Garvin Hicking voted on patch set 19 CR +1 V +1 04/10/25, 09:11
-
Stefan Bürk voted on patch set 19 CR +1 V +1 04/10/25, 09:24
-
Stefan Bürk commented on patch set 19 CR 0 V 0 04/10/25, 09:28
AbstractTask.php:477```suggestion if (property_exists($this, $key)) { ``` I'd say that this should be a proper property check .. isset() would return false even if the property exists but is set to "null" (nullable property) -
Stefan Bürk commented on patch set 20
CR +1V +104/10/25, 09:36Published edit on patch set 19. -
core-ci voted on patch set 20 V +1 04/10/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77419
-
Stefan Bürk commented on patch set 20 04/10/25, 09:43
AbstractTask.php:477ReplyMy bad, was not on the latest changeset. -
Garvin Hicking voted on patch set 20 CR +1 V +1 04/10/25, 09:52
-
Christian Kuhn voted on patch set 20 CR +1 V +1 04/10/25, 10:39
-
Benni Mack commented on patch set 20 CR +2 V +2 04/10/25, 10:44
Thank you, everybody -
Benni Mack merged patch set 21 04/10/25, 10:44
SchedulerDatabaseStorageMigration.php:32