Review 13.4 Merged

88680[BUGFIX] Move flex form inline children along with its parent

Christian Kuhn CR +2 V +2 Nightmare +3683 −102 updated 03/22/25, 08:03

Commit message

When a record is moved to a different page, flex form inline
children have to be moved to that pid as well, just like "casual"
inline children. Current DataHandler does not do this. This can
lead to falsely deleted records if an old source page is later
deleted by an editor.

The patch establishes fixes and test scenarios for flexform inline
to see if children are properly moved when a parent is moved. The
change goes along with an additional refactoring within moveRecord(),
aiming to make everything more obvious and less convoluted. The test
.csv files have some `@todo` comments that outline fishy sorting and
workspace related details. Those should be elaborated on with
upcoming changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 31

Show 11 more files

Review log 34

  1. Christian Kuhn uploaded patch set 1 03/22/25, 07:32

  2. core-ci voted on patch set 1 V +1 03/22/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76007

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 03/22/25, 08:03

  4. Christian Kuhn merged patch set 2 03/22/25, 08:03