88683[TASK] Use Schema API in ElementHistoryController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1722
-
Benni Mack uploaded patch set 1 03/22/25, 12:21
-
Benni Mack uploaded patch set 2 03/22/25, 12:28
-
core-ci voted on patch set 1 V +1 03/22/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76018
-
Benni Mack marked it work in progress 03/22/25, 12:35
-
core-ci voted on patch set 2 V +1 03/22/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76019
-
Benni Mack updated the commit message in patch set 3
V +103/22/25, 15:46 -
Benni Mack marked it ready for review 03/22/25, 15:46
-
core-ci voted on patch set 3 V +1 03/22/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76030
-
Georg Ringer voted on patch set 3 CR +1 V +1 03/23/25, 20:20
-
Simon Schaufelberger commented on patch set 3 03/23/25, 23:09
ElementHistoryController.php:483since types were added on other methods, can they be added here as well? -
Benni Mack uploaded patch set 4
CR +1V +103/24/25, 20:10 -
Benni Mack commented on patch set 4 03/24/25, 20:10
ElementHistoryController.php:446ReplyDoneElementHistoryController.php:483ReplyDone -
core-ci voted on patch set 4 V +1 03/24/25, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76172
-
Andreas Kienast commented on patch set 4 03/25/25, 12:01
ElementHistoryController.php:475The return value looks inversed. Previously, if `ignoreRootLevelRestriction` was true, the method returned false, this is apparently not given anymore. Right? -
Benni Mack commented on patch set 4 03/25/25, 12:24
ElementHistoryController.php:475Replygood catch! -
Benni Mack uploaded patch set 5
V +103/25/25, 14:15 -
Benni Mack commented on patch set 5 03/25/25, 14:16
ElementHistoryController.php:475ReplyDone -
core-ci voted on patch set 5 V +1 03/25/25, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76262
-
Andreas Kienast voted on patch set 5 CR +1 V +1 03/25/25, 14:36
-
Christian Kuhn voted on patch set 5 CR +1 V +1 03/25/25, 15:18
-
Benni Mack commented on patch set 5 CR +2 V +2 03/25/25, 15:22
muchas gracias for the feedback! -
Benni Mack merged patch set 6 03/25/25, 15:22
ElementHistoryController.php:446