Review main Merged

88683[TASK] Use Schema API in ElementHistoryController

Benni Mack CR +2 V +2 Normal +36 −52 updated 03/25/25, 15:22

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1722

  1. Benni Mack uploaded patch set 1 03/22/25, 12:21

  2. Benni Mack uploaded patch set 2 03/22/25, 12:28

  3. core-ci voted on patch set 1 V +1 03/22/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76018

  4. Benni Mack marked it work in progress 03/22/25, 12:35

  5. core-ci voted on patch set 2 V +1 03/22/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76019

  6. Benni Mack updated the commit message in patch set 3 V +1 03/22/25, 15:46

  7. Benni Mack marked it ready for review 03/22/25, 15:46

  8. core-ci voted on patch set 3 V +1 03/22/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76030

  9. Georg Ringer voted on patch set 3 CR +1 V +1 03/23/25, 20:20

  10. Simon Schaufelberger commented on patch set 3 03/23/25, 23:09

    ElementHistoryController.php:446

    uid is missing type while the method below got it. Intended?

    ElementHistoryController.php:483

    since types were added on other methods, can they be added here as well?
  11. Benni Mack uploaded patch set 4 CR +1 V +1 03/24/25, 20:10

  12. Benni Mack commented on patch set 4 03/24/25, 20:10

    ElementHistoryController.php:446 Reply

    Done

    ElementHistoryController.php:483 Reply

    Done
  13. core-ci voted on patch set 4 V +1 03/24/25, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76172

  14. Andreas Kienast commented on patch set 4 03/25/25, 12:01

    ElementHistoryController.php:475

    The return value looks inversed. Previously, if `ignoreRootLevelRestriction` was true, the method returned false, this is apparently not given anymore. Right?
  15. Benni Mack commented on patch set 4 03/25/25, 12:24

    ElementHistoryController.php:475 Reply

    good catch!
  16. Benni Mack uploaded patch set 5 V +1 03/25/25, 14:15

  17. Benni Mack commented on patch set 5 03/25/25, 14:16

    ElementHistoryController.php:475 Reply

    Done
  18. core-ci voted on patch set 5 V +1 03/25/25, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76262

  19. Andreas Kienast voted on patch set 5 CR +1 V +1 03/25/25, 14:36

  20. Christian Kuhn voted on patch set 5 CR +1 V +1 03/25/25, 15:18

  21. Benni Mack commented on patch set 5 CR +2 V +2 03/25/25, 15:22

    muchas gracias for the feedback!
  22. Benni Mack merged patch set 6 03/25/25, 15:22