88687[!!!][TASK] Use native types and fix proper return types in FAL
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
-
Verified V +2 Done
- Georg Ringer +2
- core-ci +1 CI
Issues 1
Files 34
- Build/phpstan/phpstan-baseline.neon+0 −204
- typo3/sysext/core/Classes/Resource/Collection/FolderBasedFileCollection.php2+6 −12
- typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php+1 −2
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+34 −85
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+19 −61
- typo3/sysext/core/Classes/Resource/Processing/TaskTypeRegistry.php+3 −11
- typo3/sysext/core/Classes/Resource/Search/Result/DriverFilteredSearchResult.php+9 −25
- typo3/sysext/core/Classes/Resource/Security/FilePermissionAspect.php+2 −3
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php+1 −1
- typo3/sysext/core/Classes/Resource/AbstractFile.php6+24 −34
- typo3/sysext/core/Classes/Resource/File.php+11 −30
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+14 −28
- typo3/sysext/core/Classes/Resource/FileInterface.php+4 −1
- typo3/sysext/core/Classes/Resource/FileReference.php+21 −47
- typo3/sysext/core/Classes/Resource/Folder.php2+32 −62
- typo3/sysext/core/Classes/Resource/FolderInterface.php6+6 −2
- typo3/sysext/core/Classes/Resource/InaccessibleFolder.php+17 −95
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php+12 −37
- typo3/sysext/core/Classes/Resource/ProcessedFile.php2+3 −7
- typo3/sysext/core/Classes/Resource/ResourceFactory.php2+23 −53
Show 14 more files
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+176 −393
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106427-FileAbstractionLayerRelatedChanges.rstnew+39 −0
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+2 −3
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+4 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php+1 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/FileConverter.php+1 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/FileReferenceConverter.php+1 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/FolderConverter.php+1 −4
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+1 −1
Review log 4369
Show 2544 earlier messages
-
Benni Mack uploaded patch set 1 03/23/25, 17:31
-
core-ci voted on patch set 1 V -1 03/23/25, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76071
-
Benni Mack uploaded patch set 2
V -103/23/25, 19:37 -
core-ci voted on patch set 2 V -1 03/23/25, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76083
-
Benni Mack uploaded patch set 3
V -103/23/25, 19:57 -
core-ci voted on patch set 3 V -1 03/23/25, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76085
-
Benni Mack uploaded patch set 4
V -103/23/25, 21:12 -
Benni Mack uploaded patch set 5 03/23/25, 21:19
-
core-ci voted on patch set 4 V -1 03/23/25, 21:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76087
-
core-ci voted on patch set 5 V -1 03/23/25, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76088
-
Benni Mack uploaded patch set 6
V -103/23/25, 22:07 -
core-ci voted on patch set 6 V -1 03/23/25, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76096
-
Benni Mack uploaded patch set 7
V -103/23/25, 22:28 -
core-ci voted on patch set 7 V -1 03/23/25, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76100
-
Benni Mack marked it work in progress 03/23/25, 22:57
-
Benni Mack uploaded patch set 8
V -103/24/25, 22:38 -
core-ci voted on patch set 8 V -1 03/24/25, 22:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76189
-
Benni Mack uploaded patch set 9
V -103/24/25, 23:02 -
core-ci voted on patch set 9 V -1 03/24/25, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76190
-
Benni Mack uploaded patch set 10
V -103/24/25, 23:12 -
core-ci voted on patch set 10 V -1 03/24/25, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76191
-
Benni Mack uploaded patch set 11
V -103/24/25, 23:25 -
core-ci voted on patch set 11 V -1 03/24/25, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76192
-
Benni Mack uploaded patch set 12
V -103/24/25, 23:34 -
core-ci voted on patch set 12 V +1 03/24/25, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76193
-
Benni Mack uploaded patch set 13
V +103/25/25, 10:21 -
Benni Mack uploaded patch set 14 03/25/25, 10:26
-
core-ci voted on patch set 13 V -1 03/25/25, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76232
-
core-ci voted on patch set 14 V -1 03/25/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76233
-
Benni Mack uploaded patch set 15
V -103/25/25, 10:37 -
core-ci voted on patch set 15 V +1 03/25/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76235
-
Benni Mack updated the commit message in patch set 16
V +103/25/25, 13:36 -
Benni Mack marked it ready for review 03/25/25, 13:37
-
core-ci voted on patch set 16 V +1 03/25/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76257
-
Benni Mack uploaded patch set 17
V +103/25/25, 14:03 -
core-ci voted on patch set 17 V +1 03/25/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76260
-
Stefan Bürk commented on patch set 18
V +103/25/25, 15:35Published edit on patch set 17. -
core-ci voted on patch set 18 V +1 03/25/25, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76281
-
Andreas Kienast commented on patch set 18 03/25/25, 16:16
ProcessedFile.php:182We do not need this call anymore at all?ResourceFactory.php:88x. -
Benni Mack uploaded patch set 19
V +103/25/25, 16:52 -
Benni Mack commented on patch set 18 03/25/25, 16:52
ProcessedFile.php:182Replythanks. fixed!ResourceFactory.php:88ReplyDone -
core-ci voted on patch set 19 V +1 03/25/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76297
-
Stefan Bürk commented on patch set 19 03/26/25, 09:17
AbstractFile.php:49```suggestion protected string $name = ''; ``` This should be initialized at least with an empty string. The `AbstractFile` does not set this property in anyway,`File` set it within the constructor which is safe. However, `ProcessedFile` does not and provides a `setName()` method which is itself safe. Calling `getName()` before a name has been set leads to an FatalError. To make this a little bit more safer I would add the empty string default here. What do you think ? https://3v4l.org/lU5XtAbstractFile.php:440```suggestion * @throws \RuntimeException ```FolderBasedFileCollection.php:47```suggestion protected bool $recursive = false; ``` Properties not ensured set by an constructor should have a sane default value OR be nullable with a default of null to avoid errors. I suggest to set the default here to false to avoid errors when read access to property happens before setting it. typo3/sysext/core/Classes/Resource/Collection/FolderBasedFileCollection.php Note that this is only an issue when native types are set, without a type there is no vialation.ResourceStorage.php:206```suggestion protected DriverInterface $driver, protected array $storageRecord, ``` I guess we could make them CPP and remove the properties + assignments ? What do you think ? (If we are on it going through these classes) -
Benni Mack uploaded patch set 20
V +103/26/25, 14:20
-
Benni Mack commented on patch set 19 03/26/25, 14:20
AbstractFile.php:49ReplyDoneAbstractFile.php:440ReplyDoneFolderBasedFileCollection.php:47ReplyDoneResourceStorage.php:206ReplyDone -
core-ci voted on patch set 20 V +1 03/26/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76388
-
Stefan Bürk voted on patch set 20 CR +1 V +1 03/27/25, 14:43
-
Georg Ringer commented on patch set 20 03/27/25, 15:21
AbstractFile.php:404can we add return types as well? also belowFolder.php:96can we rename it to $identifier or $rootIdentifierFolderInterface.php:83should we keep that? -
Oliver Klee commented on patch set 20 03/27/25, 15:50
FolderInterface.php:65This should stay. This allows PHPStan to recognize that this method returns the same instance (instead of any instance of the same class). https://phpstan.org/writing-php-code/phpdoc-types#static-and-%24this -
Benni Mack uploaded patch set 21
CR +1V +103/27/25, 15:54 -
Benni Mack commented on patch set 20 03/27/25, 15:55
AbstractFile.php:404ReplyDoneFolder.php:96ReplyDoneFolderInterface.php:83ReplyDone -
core-ci voted on patch set 21 V -1 03/27/25, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76478
-
Benni Mack commented on patch set 21 03/27/25, 16:07
FolderInterface.php:65Replyfeel free to improve -
Oliver Klee commented on patch set 21 03/27/25, 16:29
FolderInterface.php:65ReplyWill do when the build is green again. -
Benni Mack marked it work in progress 03/27/25, 17:13
-
Georg Ringer uploaded patch set 22
V -103/27/25, 20:16 -
core-ci voted on patch set 22 V -1 03/27/25, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76504
-
Georg Ringer uploaded patch set 23
V -103/31/25, 20:46 -
core-ci voted on patch set 23 V -1 03/31/25, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76733
-
Benni Mack uploaded patch set 24
V -104/02/25, 05:50 -
core-ci voted on patch set 24 V +1 04/02/25, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76838
-
Oliver Klee uploaded patch set 25
V +104/02/25, 09:37 -
Oliver Klee commented on patch set 24 04/02/25, 09:37
FolderInterface.php:65ReplyDone -
core-ci voted on patch set 25 V -1 04/02/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76853
-
Oliver Klee uploaded patch set 26
V -104/02/25, 10:24 -
core-ci voted on patch set 26 V +1 04/02/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76861
-
Benni Mack marked it ready for review 04/02/25, 13:48
-
Georg Ringer voted on patch set 26 CR +2 V +2 04/02/25, 13:54
-
Georg Ringer merged patch set 27 04/02/25, 13:54