88688[BUGFIX] Skip link creation for sysfolders and spacers
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Benni Mack uploaded patch set 1 03/23/25, 17:54
-
core-ci voted on patch set 1 V -1 03/23/25, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76072
-
Georg Ringer commented on patch set 1 CR +1 V +1 03/23/25, 19:09
we got already tons of code like --- protected function isPageLinkable(array $page): bool { return !in_array((int)$page['doktype'], [PageRepository::DOKTYPE_SYSFOLDER, PageRepository::DOKTYPE_SPACER]); } --- just search for "PageRepository::DOKTYPE_SPACER", most usages are also with SYSFOLDER, maybe really time to have a constant with unlinkable pages as constant? -
Benni Mack commented on patch set 1 03/23/25, 19:10
Reply
there is another patch pending (although only for main) to make this 100% configurable. But that's for another day. -
Benni Mack uploaded patch set 2
CR +1V +103/23/25, 19:16 -
Simon Schaufelberger voted on patch set 2 CR +1 03/23/25, 19:20
-
core-ci voted on patch set 2 V +1 03/23/25, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76082
-
Stefan Bürk voted on patch set 2 CR +1 V +1 03/23/25, 19:35
-
Georg Ringer voted on patch set 2 CR +2 V +2 03/23/25, 19:40
-
Georg Ringer merged patch set 3 03/23/25, 19:40