Review main Merged

88690[TASK] Modernise Extbase QOM classes

Torben Hansen CR +2 V +2 Hard +111 −643 updated 03/26/25, 09:16

Commit message

This change modernizes all Extbase Query Object
Model classes by adding strict type declarations
and return types to all relevant classes and
interfaces.

Additionally:
* Unused @throws annotations have been removed.
* A PHPStan baseline entry related to QOM has been
  cleaned up.
* Type hints and docblocks have been aligned.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1522

  1. Torben Hansen uploaded patch set 1 03/23/25, 18:19

  2. Torben Hansen uploaded patch set 2 03/23/25, 18:20

  3. core-ci voted on patch set 1 V -1 03/23/25, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76075

  4. core-ci voted on patch set 2 V -1 03/23/25, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76076

  5. Georg Ringer uploaded patch set 3 V -1 03/23/25, 21:23

  6. core-ci voted on patch set 3 V +1 03/23/25, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76089

  7. Oliver Klee commented on patch set 3 03/24/25, 07:33

    Comparison.php:70

    This will allow PHPStan to check that `$operator` is one of the constants: ```suggestion * @param QueryInterface::OPERATOR_* $operator ```

    ComparisonInterface.php:75

    Ditto.
  8. Torben Hansen uploaded patch set 4 V +1 03/24/25, 17:56

  9. core-ci voted on patch set 4 V +1 03/24/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76161

  10. Georg Ringer voted on patch set 4 CR +1 V +1 03/24/25, 19:43

  11. Oliver Klee commented on patch set 4 03/24/25, 23:47

    Comparison.php:70 Reply

    Done

    ComparisonInterface.php:75 Reply

    Done
  12. Simon Schaufelberger commented on patch set 4 03/25/25, 01:25

    BindVariableValue.php:27

    if final, this can be private

    Comparison.php:73

    if final, these props can be private
  13. Benni Mack uploaded patch set 5 CR +1 V +1 03/25/25, 15:41

  14. Benni Mack commented on patch set 5 CR +1 V +1 03/25/25, 15:41

    BindVariableValue.php:27 Reply

    Done

    Comparison.php:73 Reply

    Done
  15. core-ci voted on patch set 5 V -1 03/25/25, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76282

  16. Benni Mack commented on patch set 6 CR +1 V +1 03/25/25, 16:10

    Published edit on patch set 5.
  17. core-ci voted on patch set 6 V -1 03/25/25, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76290

  18. Benni Mack uploaded patch set 7 V -1 03/25/25, 20:15

  19. core-ci voted on patch set 7 V +1 03/25/25, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76305

  20. Benni Mack voted on patch set 7 CR +1 V +1 03/26/25, 08:29

  21. Georg Ringer voted on patch set 7 CR +2 V +2 03/26/25, 09:16

  22. Georg Ringer merged patch set 8 03/26/25, 09:16