88690[TASK] Modernise Extbase QOM classes
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 25
- Build/phpstan/phpstan-baseline.neon+0 −72
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/AndInterface.php+2 −13
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/BindVariableValue.php2+4 −27
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/BindVariableValueInterface.php+1 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Comparison.php4+8 −40
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/ComparisonInterface.php2+1 −14
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/ConstraintInterface.php+1 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/EquiJoinCondition.php+13 −71
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/EquiJoinConditionInterface.php+2 −12
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/JoinConditionInterface.php+1 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalAnd.php+5 −34
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalNot.php+4 −22
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LogicalOr.php+8 −34
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LowerCase.php+5 −31
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/LowerCaseInterface.php+1 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/NotInterface.php+1 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Ordering.php+9 −30
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/OrderingInterface.php+3 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/OrInterface.php+2 −13
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/PropertyValue.php+4 −34
Show 5 more files
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/PropertyValueInterface.php+2 −12
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/QueryObjectModelFactory.php+18 −70
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/Statement.php+10 −37
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/UpperCase.php+5 −31
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/UpperCaseInterface.php+1 −6
Review log 1522
-
Torben Hansen uploaded patch set 1 03/23/25, 18:19
-
Torben Hansen uploaded patch set 2 03/23/25, 18:20
-
core-ci voted on patch set 1 V -1 03/23/25, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76075
-
core-ci voted on patch set 2 V -1 03/23/25, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76076
-
Georg Ringer uploaded patch set 3
V -103/23/25, 21:23 -
core-ci voted on patch set 3 V +1 03/23/25, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76089
-
Oliver Klee commented on patch set 3 03/24/25, 07:33
ComparisonInterface.php:75Ditto. -
Torben Hansen uploaded patch set 4
V +103/24/25, 17:56 -
core-ci voted on patch set 4 V +1 03/24/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76161
-
Georg Ringer voted on patch set 4 CR +1 V +1 03/24/25, 19:43
-
Oliver Klee commented on patch set 4 03/24/25, 23:47
Comparison.php:70ReplyDoneComparisonInterface.php:75ReplyDone -
Simon Schaufelberger commented on patch set 4 03/25/25, 01:25
BindVariableValue.php:27if final, this can be privateComparison.php:73if final, these props can be private -
Benni Mack uploaded patch set 5
CR +1V +103/25/25, 15:41 -
Benni Mack commented on patch set 5 CR +1 V +1 03/25/25, 15:41
BindVariableValue.php:27ReplyDoneComparison.php:73ReplyDone -
core-ci voted on patch set 5 V -1 03/25/25, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76282
-
Benni Mack commented on patch set 6
CR +1V +103/25/25, 16:10Published edit on patch set 5. -
core-ci voted on patch set 6 V -1 03/25/25, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76290
-
Benni Mack uploaded patch set 7
V -103/25/25, 20:15 -
core-ci voted on patch set 7 V +1 03/25/25, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76305
-
Benni Mack voted on patch set 7 CR +1 V +1 03/26/25, 08:29
-
Georg Ringer voted on patch set 7 CR +2 V +2 03/26/25, 09:16
-
Georg Ringer merged patch set 8 03/26/25, 09:16
Comparison.php:70