88697[!!!][TASK] Use FileType Enum in FAL
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 7
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php+13 −5
- typo3/sysext/core/Classes/Resource/AbstractFile.php+3 −7
- typo3/sysext/core/Classes/Resource/FileReference.php+3 −8
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst3+2 −0
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+7 −7
Review log 1520
-
Benni Mack uploaded patch set 1 03/23/25, 22:40
-
core-ci voted on patch set 1 V -1 03/23/25, 22:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76101
-
Benni Mack uploaded patch set 2
V -103/23/25, 22:56 -
core-ci voted on patch set 2 V -1 03/23/25, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76103
-
Benni Mack uploaded patch set 3
V -103/23/25, 23:33 -
core-ci voted on patch set 3 V +1 03/23/25, 23:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76107
-
Benni Mack updated the commit message in patch set 4
V +103/23/25, 23:43 -
core-ci voted on patch set 4 V +1 03/23/25, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76108
-
Stefan Bürk voted on patch set 4 CR +1 V +1 03/24/25, 05:48
-
Garvin Hicking commented on patch set 4 03/24/25, 07:13
-
Christian Kuhn voted on patch set 4 CR +1 V +1 03/24/25, 08:52
-
Benni Mack uploaded patch set 5
CR +1V +103/24/25, 17:31 -
Benni Mack commented on patch set 5 03/24/25, 17:31
Breaking-105377-DeprecatedFunctionalityRemoved.rst:124ReplyNo Extension Scanner check, because we do not have "Changed Return Type of method" as category yet :) -
core-ci voted on patch set 5 V +1 03/24/25, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76159
-
Stefan Bürk voted on patch set 5 CR +1 V +1 03/24/25, 18:18
-
Garvin Hicking commented on patch set 5 CR +1 V +1 03/24/25, 18:57
Breaking-105377-DeprecatedFunctionalityRemoved.rst:124ReplyWhat I meant was scanning just for usages / consumers of `AbstractFile|FileReference|...childrenoftheseClasses->getType()` code access, so any place that just calls that method to report with a weak hit. But it might be too much false positive noise, so nevermind. -
Georg Ringer voted on patch set 5 CR +2 V +2 03/24/25, 19:42
-
Georg Ringer merged patch set 6 03/24/25, 19:42
-
Benni Mack commented on patch set 6 03/24/25, 19:57
I wonder if this change is actually cool... because it isn't. Fluid cannot handle Enums properly (yet). Fluids' Type.html looks like this: <html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true"> <f:switch expression="{file.type}"> <f:case value="3"> <f:render partial="Media/Type/Audio" arguments="{file: file, dimensions: dimensions, data: data, settings: settings}" /> </f:case> <f:case value="4"> <f:render partial="Media/Type/Video" arguments="{file: file, dimensions: dimensions, data: data, settings: settings}" /> </f:case> <f:defaultCase> <f:render partial="Media/Type/Image" arguments="{file: file, dimensions: dimensions, data: data, settings: settings}" /> </f:defaultCase> </f:switch> </html> and guess what... it does not work anymore. This means EVERYBODY who uses FileReferences or Files in Fluid now has a borken setup. -
Benni Mack wrote 03/24/25, 20:42
Created a revert of this change as I7c2b813d2cfe212ed801ed85706c7d116835e3a2
Breaking-105377-DeprecatedFunctionalityRemoved.rst:124