Review main Abandoned

88701[WIP][BUGFIX] Centralize Preview Link building across TYPO3 Backend

Benni Mack CR 0 V -1 Hard +143 −170 updated 06/26/25, 15:22

Commit message

Oliver Hader has introduced the PreviewUriBuilder already,
but we never got around to centralize the link generation
to other records than pages.

This was previously only possible in EXT:workspaces and FormEngine
with the "Save + View" Button.

This has now changed, as the logic
a) which pages.doktype is previewable
b) to evaluate TCEMAIN.preview is centralized within PreviewUriBuilder.
c) to never preview delete placeholder records

Still pending:
- Evaluate and rip out code in EditDocumentController
- Clean up PageProvider / RecordProvider
- Thin out Workspace Preview Builder

I need to check:
- https://forge.typo3.org/issues/96658
- https://forge.typo3.org/issues/81252
- https://forge.typo3.org/issues/82993
- https://forge.typo3.org/issues/77581
- https://forge.typo3.org/issues/96861

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 19

Review log 610

  1. Benni Mack uploaded patch set 1 03/24/25, 09:32

  2. core-ci voted on patch set 1 V -1 03/24/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76133

  3. Benni Mack marked it work in progress 03/24/25, 10:12

  4. Benni Mack updated the commit message in patch set 2 V -1 03/24/25, 20:35

  5. core-ci voted on patch set 2 V -1 03/24/25, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76177

  6. Benni Mack uploaded patch set 3 V -1 03/26/25, 09:23

  7. core-ci voted on patch set 3 V -1 03/26/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76361

  8. Benni Mack uploaded patch set 4 V -1 03/27/25, 16:37

  9. core-ci voted on patch set 4 V -1 03/27/25, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76484

  10. Benni Mack abandoned the change 06/26/25, 15:22

    work is done