Review main Merged

88713[BUGFIX] Revert "Use FileType Enum in FAL"

Benni Mack CR +2 V +2 Normal +29 −30 updated 03/24/25, 20:56

Commit message

This reverts commit 1c0bb79f71cf08aa2556a9dfe3b04e07731401ea
as all Fluid templates using FileReference accessing
filereference.type would not work anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1

Issues 1

Files 7

Review log 79

  1. Benni Mack uploaded patch set 1 03/24/25, 20:42

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 03/24/25, 20:42

  3. Garvin Hicking voted on patch set 1 CR 0 V 0 03/24/25, 20:43

  4. Benni Mack updated the commit message in patch set 2 03/24/25, 20:44

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 03/24/25, 20:50

    thx for catching this quickly, and sorry for not testing all aspects here. I'll try to create a functional test for this aspect so it doesn't happen again (at least for the exact same method) ;-)
  6. core-ci voted on patch set 1 V +1 03/24/25, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76178

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/24/25, 20:54

  8. Benni Mack merged patch set 3 03/24/25, 20:54

  9. core-ci voted on patch set 2 V +1 03/24/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76180