88713[BUGFIX] Revert "Use FileType Enum in FAL"
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
Issues 1
Files 7
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php+5 −13
- typo3/sysext/core/Classes/Resource/AbstractFile.php+7 −3
- typo3/sysext/core/Classes/Resource/FileReference.php+8 −3
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst+0 −2
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+7 −7
Review log 79
-
Benni Mack uploaded patch set 1 03/24/25, 20:42
-
Garvin Hicking voted on patch set 1 CR +1 V +1 03/24/25, 20:42
-
Garvin Hicking voted on patch set 1 CR 0 V 0 03/24/25, 20:43
-
Benni Mack updated the commit message in patch set 2 03/24/25, 20:44
-
Garvin Hicking commented on patch set 2 CR +1 V +1 03/24/25, 20:50
thx for catching this quickly, and sorry for not testing all aspects here. I'll try to create a functional test for this aspect so it doesn't happen again (at least for the exact same method) ;-) -
core-ci voted on patch set 1 V +1 03/24/25, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76178
-
Benni Mack voted on patch set 2 CR +2 V +2 03/24/25, 20:54
-
Benni Mack merged patch set 3 03/24/25, 20:54
-
core-ci voted on patch set 2 V +1 03/24/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76180