Review main Merged

88715[BUGFIX] Allow FileType enum to be exposed in FAL

Benni Mack CR +2 V +2 Normal +46 −23 updated 03/25/25, 10:16

Commit message

A new method getFileType() is added to AbstractFile
and FileReference for File Abstraction Layer,
which returns the FileType Enum introduced in v13.0.

The additional (wrong) results (as in phpstan-baseline)
will be removed with a followup change to streamline types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1116

  1. Benni Mack uploaded patch set 1 03/24/25, 21:02

  2. core-ci voted on patch set 1 V -1 03/24/25, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76185

  3. Benni Mack uploaded patch set 2 V -1 03/25/25, 08:47

  4. Benni Mack uploaded patch set 3 03/25/25, 08:54

  5. Benni Mack updated the commit message in patch set 4 03/25/25, 08:55

  6. core-ci voted on patch set 2 V -1 03/25/25, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76212

  7. Oliver Klee commented on patch set 4 03/25/25, 09:00

  8. core-ci voted on patch set 3 V -1 03/25/25, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76213

  9. core-ci voted on patch set 4 V -1 03/25/25, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76214

  10. Benni Mack commented on patch set 4 03/25/25, 09:16

    AbstractFile.php:226 Reply

    When adding this, I get: "Method TYPO3\\CMS\\Core\\Resource\\FileReference\:\:getType\(\) should return 0\|1\|2\|3\|4\|5 but returns int"
  11. Benni Mack uploaded patch set 5 V -1 03/25/25, 09:21

  12. core-ci voted on patch set 5 V +1 03/25/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76221

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 03/25/25, 09:57

  14. Stefan Bürk voted on patch set 5 CR +1 V +1 03/25/25, 10:16

  15. Benni Mack voted on patch set 5 CR +2 V +2 03/25/25, 10:16

  16. Benni Mack merged patch set 6 03/25/25, 10:16