88715[BUGFIX] Allow FileType enum to be exposed in FAL
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+1 −1
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php+13 −5
- typo3/sysext/core/Classes/Resource/AbstractFile.php2+23 −11
- typo3/sysext/core/Classes/Resource/FileReference.php+7 −4
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+2 −2
Review log 1116
-
Benni Mack uploaded patch set 1 03/24/25, 21:02
-
core-ci voted on patch set 1 V -1 03/24/25, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76185
-
Benni Mack uploaded patch set 2
V -103/25/25, 08:47 -
Benni Mack uploaded patch set 3 03/25/25, 08:54
-
Benni Mack updated the commit message in patch set 4 03/25/25, 08:55
-
core-ci voted on patch set 2 V -1 03/25/25, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76212
-
Oliver Klee commented on patch set 4 03/25/25, 09:00
-
core-ci voted on patch set 3 V -1 03/25/25, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76213
-
core-ci voted on patch set 4 V -1 03/25/25, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76214
-
Benni Mack commented on patch set 4 03/25/25, 09:16
AbstractFile.php:226ReplyWhen adding this, I get: "Method TYPO3\\CMS\\Core\\Resource\\FileReference\:\:getType\(\) should return 0\|1\|2\|3\|4\|5 but returns int" -
Benni Mack uploaded patch set 5
V -103/25/25, 09:21 -
core-ci voted on patch set 5 V +1 03/25/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76221
-
Garvin Hicking voted on patch set 5 CR +1 V +1 03/25/25, 09:57
-
Stefan Bürk voted on patch set 5 CR +1 V +1 03/25/25, 10:16
-
Benni Mack voted on patch set 5 CR +2 V +2 03/25/25, 10:16
-
Benni Mack merged patch set 6 03/25/25, 10:16
AbstractFile.php:226