Review main Merged

88735[TASK] Provide fluid-based test to retrieve FileType ENUM

Garvin Hicking CR +2 V +2 Normal +55 −0 updated 04/07/25, 10:49

Commit message

This ensures that changes to the FileType ENUM being passed
to fluid will be noticed if it no longer properly evalutes
file types.

Both `file.type` (INT) and `file.fileType` (ENUM) cases
are covered.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 811

  1. Garvin Hicking uploaded patch set 1 03/25/25, 09:57

  2. core-ci voted on patch set 1 V +1 03/25/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76228

  3. Garvin Hicking uploaded patch set 2 V +1 03/25/25, 10:44

  4. core-ci voted on patch set 2 V +1 03/25/25, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76236

  5. Stefan Bürk commented on patch set 2 04/03/25, 07:27

    relate(d) issues sounds wrong - do not get the relation for this change when opening them. Did you messed up with gerrit change numbers by any change ?
  6. Garvin Hicking updated the commit message in patch set 3 V +1 04/03/25, 07:31

  7. Garvin Hicking commented on patch set 3 04/03/25, 07:32

    Reply

    yeah, copypasta. Fixed, thanks!
  8. core-ci voted on patch set 3 V +1 04/03/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76927

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 04/03/25, 07:54

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 04/07/25, 10:41

  11. Christian Kuhn merged patch set 4 04/07/25, 10:49