Review main Merged

88738[BUGFIX] Show share link even if shortcuts are disabled

Benni Mack CR +2 V +2 Normal +40 −35 updated 03/28/25, 07:59

Commit message

When a user has this TSconfig:
options {
  enableBookmarks = 1
  mayNotCreateEditBookmarks = 0
}

then it should still show the Share button, which is hidden
in the dropdown toggle button, which was previously only
shown if the user was allowed to create a shortcut.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 03/25/25, 12:30

  2. core-ci voted on patch set 1 V -1 03/25/25, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76245

  3. Andreas Kienast commented on patch set 1 03/25/25, 12:50

    ShortcutButton.php:186

    This looks falsely negated
  4. Benni Mack commented on patch set 2 V -1 03/25/25, 12:51

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 03/25/25, 12:52

    ShortcutButton.php:186 Reply

    Done
  6. core-ci voted on patch set 2 V -1 03/25/25, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76248

  7. Benni Mack uploaded patch set 3 V -1 03/25/25, 13:27

  8. core-ci voted on patch set 3 V +1 03/25/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76256

  9. Georg Ringer voted on patch set 3 CR +1 V +1 03/27/25, 20:59

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 03/28/25, 07:30

  11. Benni Mack merged patch set 4 03/28/25, 07:59