Review main Merged

88739[TASK] Have workspace aware inline children

Christian Kuhn CR +2 V +2 Nightmare +252 −5687 updated 07/17/25, 13:13

Commit message

Scenario: A parent table with a type=inline and foreign_table
definition, either as direct DB column, or within a flex form.
The parent table *is* workspace aware (ctrl versioningWS = true),
the child table *is not* workspace aware (ctrl versioningWS = false
or not set).

This scenario leads to a plethora of issues: It starts with
multiple PHP array error access warnings, the refindex does not deal
with it, there are hard logical issues on DB level, and the backend
UI does not deal with it in a sane way by failing to notify workspace
editors they are currently editing live content.

The decision is now: This scenario is not supported. When an inline
parent table is workspace aware, attached "foreign_table" based child
tables have to be workspace aware as well.

The patch adds a TCA migration to scan for this scenario and to make
affected child tables workspace aware automatically. This is always
done, even if the workspace extension is not loaded to prevent
issues when extension authors do not develop with workspaces in mind
but extension users have workspaces loaded.

Notes:
* The change takes care of type=inline with foreign_table only. It does
  not deal with type=group,select,file,category or inline with MM. We
  *may* extend this later, but TYPO3 core has a type=group based relation
  from workspace enabled sys_file_reference to not workspace enabled
  sys_file, which needs to be supported.
* The migration does not detect a workspace aware parent when the
  inline relation is part of a flex form field definition. This is due
  to current restrictions of flex forms and its on-the-fly migration.
  In those relations, a not workspace aware child table is not migrated,
  developers should still make those child tables workspace aware. Further
  refactorings of TCA flex form definitions may however make this scenario
  auto-migratable as well.
* The patch removes the related test scenarios we created with #98103.
  The change is targeted to main, but we may have a v13 change to remove
  those tests as well to prevent useless test fails when dealing with
  issues.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 106

Show 86 more files

Review log 1929

Show 34 earlier messages
  1. Christian Kuhn uploaded patch set 1 03/25/25, 12:34

  2. core-ci voted on patch set 1 V -1 03/25/25, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76246

  3. Benni Mack marked it work in progress 04/16/25, 10:51

  4. Christian Kuhn uploaded patch set 2 V -1 06/04/25, 09:51

  1. Christian Kuhn uploaded patch set 3 06/04/25, 09:58

  2. core-ci voted on patch set 2 V -1 06/04/25, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79844

  3. Christian Kuhn uploaded patch set 4 06/04/25, 10:06

  4. core-ci voted on patch set 3 V -1 06/04/25, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79846

  5. core-ci voted on patch set 4 V +1 06/04/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79848

  6. Christian Kuhn uploaded patch set 5 V +1 06/04/25, 10:24

  7. core-ci voted on patch set 5 V +1 06/04/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79850

  8. Christian Kuhn uploaded patch set 6 V +1 06/04/25, 10:57

  9. core-ci voted on patch set 6 V +1 06/04/25, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79853

  10. Christian Kuhn uploaded patch set 7 V +1 06/04/25, 12:38

  11. Christian Kuhn marked it ready for review 06/04/25, 12:39

  12. Oli Bartsch uploaded patch set 8 06/04/25, 12:43

  13. Christian Kuhn uploaded patch set 9 06/04/25, 12:43

  14. Oli Bartsch voted on patch set 8 CR +1 V +1 06/04/25, 12:43

  15. Oli Bartsch uploaded patch set 10 06/04/25, 12:44

  16. Oli Bartsch voted on patch set 10 CR +1 V +1 06/04/25, 12:44

  17. core-ci voted on patch set 7 V +1 06/04/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79856

  18. core-ci voted on patch set 8 V +1 06/04/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79857

  19. core-ci voted on patch set 9 V +1 06/04/25, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79858

  20. core-ci voted on patch set 10 V +1 06/04/25, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79859

  21. Stefan Bürk voted on patch set 10 CR +1 V +1 06/04/25, 13:02

  22. Christian Kuhn voted on patch set 10 CR +2 V +2 06/04/25, 13:18

  23. Christian Kuhn commented on patch set 10 06/04/25, 13:19

    has a private +1 from benni as well.
  24. Christian Kuhn merged patch set 11 06/04/25, 13:19

  25. Lina Wolf commented on patch set 11 07/17/25, 13:13