Review main Merged

88741[BUGFIX] Correct misaligned field debug information in form labels

Benjamin Kott CR +2 V +2 Easy +13 −6 updated 03/25/25, 15:51

Commit message

Adjusted the `code` element within form-labels to ensure debug
information aligns with the text flow, addressing issues caused
by limited space when using `display: flex` for severity icons and
labels. The `code` element no longer behaves as a flex target,
maintaining proper alignment.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Benjamin Kott uploaded patch set 1 03/25/25, 12:56

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 03/25/25, 13:01

  3. core-ci voted on patch set 1 V +1 03/25/25, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76251

  4. Benjamin Franzke commented on patch set 1 CR +1 V +1 03/25/25, 14:02

    _form-label.scss:17

    I would prefer `flex-wrap: wrap` on `.form-label` instead, but I understand that we cannot do that because of the `:before` has-change indicators which would also wrap before the label then… What I dislike about `display: contents` in this case is, that it only works when there is a space char before `<code>`, as it is just interpreted as text and `gap` is ignored. Anyway, fine by me.
  5. Benjamin Kott voted on patch set 1 CR +2 V +2 03/25/25, 15:14

  6. Benjamin Kott merged patch set 2 03/25/25, 15:51