Review 12.4 Merged

88745[TASK] Avoid loading metadata for files when obtaining the "file" property

Benni Mack CR +2 V +2 Easy +2 −0 updated 03/25/25, 15:20

Commit message

Because FAL loads all files in one folder before applying a pagination
strategy, custom drivers, that make use of heavy i/o tasks may have very
poor performance, especially when dealing with many files in one folder.

By avoiding access to the metadata of a file the response time can still be
reduced substantially.

The default file-list rendering will sort by "file" which is the sys_file
uid but will be obtained via the metadata aspect. This is not necessary as
the file object should be able to return the "name" without using the
metadata aspect.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 03/25/25, 15:07

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 03/25/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76269

  3. Benni Mack voted on patch set 1 CR +2 V +2 03/25/25, 15:19

  4. Benni Mack merged patch set 2 03/25/25, 15:20